Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix de-/serialization for AAS with extension(s) #136

Merged
merged 10 commits into from
Jul 11, 2023
Merged

Fix de-/serialization for AAS with extension(s) #136

merged 10 commits into from
Jul 11, 2023

Conversation

mjacoby
Copy link
Contributor

@mjacoby mjacoby commented Jun 19, 2023 •
edited
Loading

This fixes the issue for JSON.
Additional unit tests should be added for XML and AASX.

Superseeds #135

@alexgordtop
Copy link
Contributor

Thanks, that fixes my issue :)

@alexgordtop alexgordtop mentioned this pull request Jun 19, 2023
Closed
@twebermartins twebermartins added the bug Something isn't working label Jun 19, 2023
@mjacoby
Copy link
Contributor Author

mjacoby commented Jun 20, 2023 •
edited by FrankSchnicke
Loading

@twebermartins twebermartins added the V.1.0.0 Final Release V.1.0.0 following EF processes label Jul 4, 2023
@mjacoby
Add minimal and maximal example for extension
1ab0c5b 
* adds Java respresentation of test cases in core
* adds corresponding unit tests in dataformat-json
@mjacoby
fix imports
9c6fb8e
@mjacoby
Copy link
Contributor Author

mjacoby commented Jul 7, 2023

@FrankSchnicke Java classes are now available in dataformat-core (see https://github.com/eclipse-aas4j/aas4j/blob/bugfix/has-extensions/dataformat-core/src/test/java/org/eclipse/digitaltwin/aas4j/v3/dataformat/core/Examples.java). Please add corresponding unit tests for de-/serialization of XML.

@FrankSchnicke FrankSchnicke mentioned this pull request Jul 10, 2023
Merged
@FrankSchnicke
Removes obsolete test case
5d6ee5d 
* Is superseded by Extension-Maximal.json

Signed-off-by: Frank Schnicke <frank.schnicke@iese.fraunhofer.de>
@FrankSchnicke
Adds license text for admin-shell-io examples & Moves files to separa…
6f55fb9 
…te folder

* Allows copy & pasting from admin-shell-io repo

Signed-off-by: Frank Schnicke <frank.schnicke@iese.fraunhofer.de>
@FrankSchnicke
Extension serialization working
ff2dfc8 
Signed-off-by: Frank Schnicke <frank.schnicke@iese.fraunhofer.de>
@FrankSchnicke
Extension deserialization working
2b36604 
Signed-off-by: Frank Schnicke <frank.schnicke@iese.fraunhofer.de>
@FrankSchnicke
Copy link
Contributor

@mjacoby ready for review

@mjacoby mjacoby merged commit 80ae3e9 into main Jul 11, 2023
@mjacoby mjacoby deleted the bugfix/has-extensions branch July 11, 2023 09:21
@FrankSchnicke FrankSchnicke mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mjacoby mjacoby

Labels
bug Something isn't working V.1.0.0 Final Release V.1.0.0 following EF processes
Projects
Eclipse AAS4J Dev
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjacoby @alexgordtop @FrankSchnicke @twebermartins