Adding CustomDataspecification Feature and UnitTests #207
Conversation
|
Soves #14 |
sebbader-sap
requested review from
FrankSchnicke and
mjacoby
and removed request for
FrankSchnicke
|
|
||
| private DataSpecificationIec61360 createDefaultDataSpecificationIec61360FromNode(JsonParser parser, JsonNode nodeContent) throws IOException { | ||
| return DeserializationHelper.createInstanceFromNode(parser, nodeContent, DefaultDataSpecificationIec61360.class); | ||
| return null; |
There was a problem hiding this comment.
throw exception
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.eclipse.digitaltwin.aas4j.v3.model; |
...ormat-core/src/test/java/org/eclipse/digitaltwin/aas4j/v3/model/CustomDataSpecification.java
Outdated
Show resolved
Hide resolved
...mat-xml/src/test/java/org/eclipse/digitaltwin/aas4j/v3/dataformat/xml/XmlSerializerTest.java
Outdated
Show resolved
Hide resolved
* reuse same environment for JSON and XML tests * rename DataSpecification to DummyDataSpecfication
|
@FrankSchnicke I just uploaded the changes about which we talked yesterday. I am still struggling with https://github.com/sap-contributions/aas4j/blob/c33a3aaf8db2e52c0b5593917095d6aa09c60a27/dataformat-xml/src/main/java/org/eclipse/digitaltwin/aas4j/v3/dataformat/xml/serialization/EmbeddedDataSpecificationSerializer.java#L45 but just don't have a better idea. |
By defining it as mandatory to extend/implement the CustomDataSpecification interface I think we have a good starting point for version 1. We can extend this in future to support a more flexible model. |
|
Another way to approach this problem would be to use annotations. |
No description provided.