Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds further compatibility with AASX Package Explorer & fine-tunes warning messages #278

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Adds further compatibility with AASX Package Explorer & fine-tunes warning messages #278

merged 2 commits into from
Apr 10, 2024

Conversation

FrankSchnicke
Copy link
Contributor

This is fix similar to #238

@FrankSchnicke
Adds further compatibility with AASX Package Explorer & fine-tunes wa…
6903ecf 
…rning messages

Signed-off-by: Frank Schnicke <frank.schnicke@iese.fraunhofer.de>
mjacoby
mjacoby requested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@mjacoby mjacoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks good but I noticed some legacy issues that return immutable list which does not seem appropriate and probably should be changed to avoid problems in the future.

...at-aasx/src/main/java/org/eclipse/digitaltwin/aas4j/v3/dataformat/aasx/AASXDeserializer.java Outdated Show resolved Hide resolved
...italtwin/aas4j/v3/dataformat/xml/internal/deserialization/OperationVariableDeserializer.java Outdated Show resolved Hide resolved
...italtwin/aas4j/v3/dataformat/xml/internal/deserialization/OperationVariableDeserializer.java Outdated Show resolved Hide resolved
...ipse/digitaltwin/aas4j/v3/dataformat/xml/internal/deserialization/QualifierDeserializer.java Outdated Show resolved Hide resolved
...ipse/digitaltwin/aas4j/v3/dataformat/xml/internal/deserialization/QualifierDeserializer.java Outdated Show resolved Hide resolved
@FrankSchnicke
Adresses review remarks
876bf7f 
Signed-off-by: Frank Schnicke <frank.schnicke@iese.fraunhofer.de>
@FrankSchnicke
Copy link
Contributor Author

I scanned the xml project for other instances of Collections.emptyList() and Collections.singletonList() and replaced them.

mjacoby
mjacoby approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@mjacoby mjacoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now.

@FrankSchnicke FrankSchnicke merged commit e240ddc into main Apr 10, 2024
4 checks passed
@FrankSchnicke FrankSchnicke deleted the update/compatibility branch April 10, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjacoby mjacoby mjacoby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankSchnicke @mjacoby