chore(core): Use lists defined in JobStatus class instead of set

Signed-off-by: Johanna Lamppu <johanna.lamppu@doubleopen.org>
eclipse-apoapsis · Dec 12, 2024 · e0fc56e · e0fc56e
1 parent cfab321
commit e0fc56e
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/core/src/main/kotlin/api/RunsRoute.kt b/core/src/main/kotlin/api/RunsRoute.kt
@@ -277,12 +277,10 @@ fun Route.runs() = route("runs") {
 
                     val jobs = repositoryService.getJobs(ortRun.repositoryId, ortRun.index)
 
-                    val finishedStateSet: Set<JobStatus> = setOf(JobStatus.FINISHED, JobStatus.FINISHED_WITH_ISSUES)
-
-                    val analyzerJobInFinalState = jobs?.analyzer?.status in finishedStateSet.plus(JobStatus.FAILED)
-                    val analyzerJobInFinishedState = jobs?.analyzer?.status in finishedStateSet
-                    val advisorJobInFinishedState = jobs?.advisor?.status in finishedStateSet
-                    val evaluatorJobInFinishedState = jobs?.evaluator?.status in finishedStateSet
+                    val analyzerJobInFinalState = jobs?.analyzer?.status in JobStatus.FINAL_STATUSES
+                    val analyzerJobInFinishedState = jobs?.analyzer?.status in JobStatus.SUCCESSFUL_STATUSES
+                    val advisorJobInFinishedState = jobs?.advisor?.status in JobStatus.SUCCESSFUL_STATUSES
+                    val evaluatorJobInFinishedState = jobs?.evaluator?.status in JobStatus.SUCCESSFUL_STATUSES
 
                     val issuesCount = if (analyzerJobInFinalState) issueService.countForOrtRunId(ortRun.id) else null