Change the web site title according to the viewed org / product / repo #1573
Assignees
Labels
Comments
sschuberth
added
enhancement
sschuberth
changed the title
sschuberth
changed the title
|
It's currently specified statically here. Need to inspect ways to change it dynamically; there are ways to do that. |
|
Documenting a bit further for whoever will do this: there is probably a simple way to do this dynamically by a self-written hook and a document wrapper component. Probably the breadcrumb info could also be used. |
|
@sschuberth Something like this? I'm wondering whether we actually need to show "ORT Server" in the title on those subpages, because there's already the server icon? Long titles are cut from the end, and leaving "ORT Server" out from the title would make it a bit more readable. Anything more you'd like to see in the title, considering it should probably be kept quite tight?
|
Let's do as discussed in the daily. |
Etsija
added a commit
that referenced
this issue
Dec 9, 2024
Improve the UX when several tabs are running the UI, by showing in the title of the tab either 1) Name of the organization; 2) Name of the product; or 3) When "inside" the repository pages, URL of the repository As I am unsure whether this is the right way to do it, this is so far a draft PR. There is at least one problem with this: Title is switched to the organization/product, when navigating to those pages, but it is illogically changed into the repository URL just by hovering the mouse over the repository URL in the product main page. A proper way to do this would probably be that the title changes to the repository URL for all subroutes of `...repositories/$repoId`, but I am currently lacking information on how to match all these sub-routes, and in which file/directory this change should reside. Resolves #1573. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Etsija
added a commit
that referenced
this issue
Dec 9, 2024
Improve the UX when several tabs are running the UI, by showing in the title of the tab either 1) Name of the organization; 2) Name of the product; or 3) When "inside" the repository pages, URL of the repository As I am unsure whether this is the right way to do it, this is so far a draft PR. There is at least one problem with this: Title is switched to the organization/product, when navigating to those pages, but it is illogically changed into the repository URL just by hovering the mouse over the repository URL in the product main page. A proper way to do this would probably be that the title changes to the repository URL for all subroutes of `...repositories/$repoId`, but I am currently lacking information on how to match all these sub-routes, and in which file/directory this change should reside. Resolves #1573. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Etsija
added a commit
that referenced
this issue
Dec 9, 2024
Improve the UX when several tabs are running the UI, by showing in the title of the tab either 1) Name of the organization; 2) Name of the product; or 3) When "inside" the repository pages, URL of the repository As I am unsure whether this is the right way to do it, this is so far a draft PR. There is at least one problem with this: Title is switched to the organization/product, when navigating to those pages, but it is illogically changed into the repository URL just by hovering the mouse over the repository URL in the product main page. A proper way to do this would probably be that the title changes to the repository URL for all subroutes of `...repositories/$repoId`, but I am currently lacking information on how to match all these sub-routes, and in which file/directory this change should reside. Resolves #1573. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Etsija
added a commit
that referenced
this issue
Dec 9, 2024
Improve the UX when several tabs are running the UI, by showing in the title of the tab either 1) Name of the organization; 2) Name of the product; or 3) When "inside" the repository pages, URL of the repository As I am unsure whether this is the right way to do it, this is so far a draft PR. There is at least one problem with this: Title is switched to the organization/product, when navigating to those pages, but it is illogically changed into the repository URL just by hovering the mouse over the repository URL in the product main page. A proper way to do this would probably be that the title changes to the repository URL for all subroutes of `...repositories/$repoId`, but I am currently lacking information on how to match all these sub-routes, and in which file/directory this change should reside. Resolves #1573. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Etsija
added a commit
that referenced
this issue
Dec 9, 2024
Improve the UX when several tabs are running the UI, by showing in the title of the tab either 1) Name of the organization; 2) Name of the product; or 3) When "inside" the repository pages, URL of the repository Resolves #1573. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Etsija
added a commit
that referenced
this issue
Dec 9, 2024
Improve the UX when several tabs are running the UI, by showing in the title of the tab either 1) Name of the organization; 2) Name of the product; or 3) When "inside" the repository pages, URL of the repository Because in the router several routes may be active at the same time (as in organization...product...repository), use a custom hook [1] to ensure the "newest" active route is being used when setting the title. Resolves #1573. [1]: https://www.30secondsofcode.org/react/s/use-title/ Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Etsija
added a commit
that referenced
this issue
Dec 9, 2024
Improve the UX when several tabs are running the UI, by showing in the title of the tab either 1) Name of the organization; 2) Name of the product; or 3) When "inside" the repository pages, URL of the repository Because in the router several routes may be active at the same time (as in organization...product...repository), use a custom hook [1] to ensure the "newest" active route is being used when setting the title. Resolves #1573. [1]: https://www.30secondsofcode.org/react/s/use-title/ Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Etsija
added a commit
that referenced
this issue
Dec 10, 2024
Improve the UX when several tabs are running the UI, by showing in the title of the tab either 1) Name of the organization; 2) Name of the product; or 3) When "inside" the repository pages, URL of the repository Because in the router several routes may be active at the same time (as in organization...product...repository), use a custom hook [1] to ensure the "newest" active route is being used when setting the title. Resolves #1573. [1]: https://www.30secondsofcode.org/react/s/use-title/ Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Etsija
added a commit
that referenced
this issue
Dec 10, 2024
Improve the UX when several tabs are running the UI, by showing in the title of the tab either 1) Name of the organization; 2) Name of the product; or 3) When "inside" the repository pages, URL of the repository Because in the router several routes may be active at the same time (as in organization...product...repository), use a custom hook [1] to ensure the "newest" active route is being used when setting the title. Resolves #1573. [1]: https://www.30secondsofcode.org/react/s/use-title/ Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Etsija
added a commit
that referenced
this issue
Dec 10, 2024
Improve the UX when several tabs are running the UI, by showing in the title of the tab either 1) Name of the organization; 2) Name of the product; or 3) When "inside" the repository pages, URL of the repository Resolves #1573. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Etsija
added a commit
that referenced
this issue
Dec 10, 2024
Improve the UX when several tabs are running the UI, by showing in the title of the tab either 1) Name of the organization; 2) Name of the product; or 3) When "inside" the repository pages, URL of the repository Resolves #1573. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Etsija
added a commit
that referenced
this issue
Dec 11, 2024
Improve the UX when several tabs are running the UI, by showing in the title of the tab either 1) Name of the organization; 2) Name of the product; or 3) When "inside" the repository pages, URL of the repository Resolves #1573. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Etsija
added a commit
that referenced
this issue
Dec 31, 2024
Set the page titles according to the "deepness" of the navigated route: "ORT Server" / "Organization name - ORT Server" / "Product name - ORT Server" / "Repository URL - ORT Server". Resolves #1573. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Merged
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 31, 2024
Set the page titles according to the "deepness" of the navigated route: "ORT Server" / "Organization name - ORT Server" / "Product name - ORT Server" / "Repository URL - ORT Server". Resolves #1573. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With multiple browser tabs open, it's confusing that they all are called just "ORT Server". It would be great if there was a prefix added depending on the org / product / repo that's currently viewed.
The text was updated successfully, but these errors were encountered: