Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues endpoint #1014

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Issues endpoint #1014

merged 3 commits into from
Sep 30, 2024

Conversation

MarcelBochtler
Copy link
Member

@MarcelBochtler MarcelBochtler commented Sep 11, 2024 •
edited by sschuberth
Loading

This PR currently misses the following functionality before being ready to review:

  • Tests for the Endpoint
  • Working pagination in the IssueService / Database Query
  • Additional tests for the scanner and ORT Run issues for the Service

@MarcelBochtler MarcelBochtler force-pushed the issues-endpoint branch 3 times, most recently from e91062f to e331a0a Compare September 12, 2024 07:06
@wkl3nk wkl3nk force-pushed the issues-endpoint branch 9 times, most recently from b239039 to ce68809 Compare September 23, 2024 16:32
@wkl3nk
Copy link
Contributor

wkl3nk commented Sep 23, 2024

Based on the work of @MarcelBochtler the PR now supports sorting and pagination.
Integration tests for the REST API endpoints have been added.
Scanner issues are intentionally not included in the returned issues, as there are still some clarifications to do.

@mnonnenmacher mnonnenmacher marked this pull request as ready for review September 23, 2024 17:26
oheger-bosch
oheger-bosch reviewed Sep 24, 2024
View reviewed changes
services/hierarchy/src/main/kotlin/IssueService.kt Outdated
).where { AdvisorJobsTable.ortRunId eq ortRunId }
}

/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether this out-commented code should remain here, since it needs to be reworked anyway. Maybe better add a TODO comment (to the class) describing the current limitations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the commented out code and add a TODO with what is missing.

@wkl3nk wkl3nk force-pushed the issues-endpoint branch 2 times, most recently from 166b938 to c233526 Compare September 25, 2024 06:12
@sschuberth
Copy link
Contributor

Looks like this PR needs to be rebased in order to adapt to dc901ba.

oheger-bosch
oheger-bosch previously approved these changes Sep 27, 2024
View reviewed changes
@sschuberth sschuberth added this pull request to the merge queue Sep 27, 2024
@sschuberth
Copy link
Contributor

@wkl3nk could you please tick those boxes of @MarcelBochtler's original post that have meanwhile been implemented?

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@sschuberth
Copy link
Contributor

Also, please rebase onto latest main to get some code changes for updated dependencies, @wkl3nk.

@MarcelBochtler @wkl3nk
feat(dao): Make IssuesTable sortable
7f8f30c 
Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.com>
@MarcelBochtler @wkl3nk
refactor(dao): Allow passing an AbstractQuery for custom list queries
15b8bc1 
This allows to pass abstract queries like `Union` or `Intersect` to be
passed as a custom query.

Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.com>
@sschuberth
Copy link
Contributor

@wkl3nk the compile error can be fixed like here.

@MarcelBochtler @wkl3nk
feat(api): Implement api endpoint and service for handling Issues
5d1e178 
Add an endpoint to retrieve issues, their source and affected packages
for an ORT run.

Resolves eclipse-apoapsis#405.

Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.com>
Signed-off-by: Wolfgang Klenk <wolfgang.klenk2@bosch.com>
@sschuberth sschuberth added this pull request to the merge queue Sep 30, 2024
@sschuberth

This comment was marked as resolved.

Sign in to view
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 30, 2024
@wkl3nk

This comment was marked as resolved.

Sign in to view
@Etsija

This comment was marked as resolved.

Sign in to view
@oheger-bosch oheger-bosch added this pull request to the merge queue Sep 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 30, 2024
@oheger-bosch oheger-bosch added this pull request to the merge queue Sep 30, 2024
@wkl3nk

This comment was marked as resolved.

Sign in to view
Merged via the queue into eclipse-apoapsis:main with commit 5ea23b8 Sep 30, 2024
13 checks passed
@oheger-bosch oheger-bosch deleted the issues-endpoint branch September 30, 2024 10:32
@sschuberth
Copy link
Contributor

You can tick every checkbox except "Additional tests for the scanner and ORT Run issues for the Service".

Done.

@sschuberth sschuberth mentioned this pull request Sep 30, 2024
Closed
@sschuberth sschuberth mentioned this pull request Nov 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkl3nk wkl3nk wkl3nk left review comments

@sschuberth sschuberth sschuberth approved these changes

@oheger-bosch oheger-bosch oheger-bosch left review comments

@bs-ondem bs-ondem Awaiting requested review from bs-ondem bs-ondem is a code owner

@mnonnenmacher mnonnenmacher Awaiting requested review from mnonnenmacher mnonnenmacher is a code owner

@nnobelis nnobelis Awaiting requested review from nnobelis nnobelis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MarcelBochtler @wkl3nk @sschuberth @Etsija @oheger-bosch