Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Show job statuses in product list #1207

Conversation

lamppu
Copy link
Contributor

@lamppu lamppu commented Oct 11, 2024

If a product of an organization only has one repository, show the status of the latest run in that repository in the product list in the organization details page to get a quick overview of runs in the organization.

Screenshot from 2024-10-11 11-03-15

@lamppu lamppu requested review from Etsija and mmurto as code owners October 11, 2024 10:56
@mnonnenmacher
Copy link
Contributor

As an idea, I think showing the date of the last run would also be very helpful to get an overview.

@Etsija
Copy link
Contributor

Etsija commented Oct 11, 2024

As an idea, I think showing the date of the last run would also be very helpful to get an overview.

Maybe just a date of creation after the run status? Or, date of creation for ongoing run, date of completion for a finished one?

@lamppu
Copy link
Contributor Author

lamppu commented Oct 14, 2024

As an idea, I think showing the date of the last run would also be very helpful to get an overview.

Maybe just a date of creation after the run status? Or, date of creation for ongoing run, date of completion for a finished one?

Something like this maybe?

Product details:
Screenshot from 2024-10-14 11-09-52

Organization details:
Screenshot from 2024-10-14 11-10-39

@sschuberth
Copy link
Contributor

Something like this maybe?

Personally, I'd also be fine with simply dropping the "Started / Completed At:" lines as it's clear that an active run cannot have completed yet, so the timestamp cannot refer to that state either. In exchange, maybe do like we do for the duration of ongoing runs and print the timestamp in italics to highlight its slightly different meaning?

@lamppu
Copy link
Contributor Author

lamppu commented Oct 14, 2024

In exchange, maybe do like we do for the duration of ongoing runs and print the timestamp in italics to highlight its slightly different meaning?

Right, good idea

Signed-off-by: Johanna Lamppu <johanna.lamppu@doubleopen.org>
If a product of an organization only has one repository,
show information of the latest run in that repository in
the product list in the organization details page to get
a quick overview of runs in the organization.

Signed-off-by: Johanna Lamppu <johanna.lamppu@doubleopen.org>
@lamppu lamppu force-pushed the 914-display-job-statuses-for-products-with-a-single-repo branch from 58c0700 to 0b57e22 Compare October 14, 2024 10:06
@lamppu
Copy link
Contributor Author

lamppu commented Oct 14, 2024

Screenshot from 2024-10-14 12-58-19

@mmurto mmurto added this pull request to the merge queue Oct 15, 2024
@mmurto
Copy link
Contributor

mmurto commented Oct 15, 2024

@mnonnenmacher, after you've deployed this, can you try out the performance on your infra as well? This makes a lot of requests to the API, so let's keep an eye on whether it's too much.

Merged via the queue into eclipse-apoapsis:main with commit 3d97ecb Oct 15, 2024
14 checks passed
@mmurto mmurto deleted the 914-display-job-statuses-for-products-with-a-single-repo branch October 15, 2024 07:00
@mnonnenmacher
Copy link
Contributor

@mnonnenmacher, after you've deployed this, can you try out the performance on your infra as well? This makes a lot of requests to the API, so let's keep an eye on whether it's too much.

If it causes issues we could consider (optionally) including that information directly in the products response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants