Small improvements to the EnvironmentConfigLoader
#1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
requested review from
bs-ondem,
MarcelBochtler,
mnonnenmacher,
nnobelis and
oheger-bosch
as code owners
The previous code was effectively doing the same as calling `appendln()` [1], which is deprecated. As no system-specific line-separator is needed here, use the recommended `appendLine()` [2] instead, which aligns with what the similar `handleInvalidVariables()` is already using. [1]: https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.text/appendln.html [2]: https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.text/append-line.html Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Reduce indentation for a better overview by returning early on no failures. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Change the `failure` parameter of `handleInvalidDefinitions()` to really only contain failures. These are cleaner semantics that better match `handleInvalidVariables()`. In order to do so, filter results earlier. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Align with `handleInvalidDefinitions()`. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
|
Issues referenced in commit messages and issues linked to this PR are in sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.