This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Allow specifying additional repository for download #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When building the e2e tests, a lot of stack traces occur. This is due to some ArtifactNotFound exceptions which are thrown during normal execution of the artifact resolver. These are expected exceptions so they should not be shown to the user. Mitigation: Overhaul exception strategy: Instead of throwing and recatching exceptions, we now directly catch exceptions and log only the relevant information. "requestFile" in IArtifactRequester may now return an empty File. This will (as before) be communicated to the user anyway as artifacts would be missing from the final report. Exceptions are only thrown if the build is not recoverable. Signed-off-by: Martin Idel <external.Martin.Idel@bosch-si.com>
Signed-off-by: Martin Idel <external.Martin.Idel@bosch-si.com>
- this allows to fill a reference repository with updated sources - this repository can be configured in the pom - in addition, a classifier can be configured in the workflow step Signed-off-by: Martin Idel <external.Martin.Idel@bosch-si.com>
Martin-Idel-SI
force-pushed
the
martin-idel-si/fix_invoker_exception_handling
branch
from
a6ff9b0 to
4d97293
Compare
blaumeiser-at-bosch
deleted the
martin-idel-si/fix_invoker_exception_handling
branch
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #147
For technical reasons, preferential download over maven central is not possible in all cases (the maven invoker always also queries maven central).
However, it is always bad style to have artifacts with same groupId, artifactId, version and classifier in different repositories which are actually different. Hence we let the user specify a classifier. The repository should then contain the artifacts with that special classifier.
Boy-Scout rule: This PR also overhauls exception handling so that no stack traces appear on the console during a successful run.