This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
feat(purl): add a purl to ArtifactCoordinates parser #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaumeiser-at-bosch
suggested changes
Sep 18, 2019
core/model/src/main/java/org/eclipse/sw360/antenna/model/util/ArtifactUtils.java
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| public static ArtifactCoordinates createArtifactCoordinates(String packageUrl) throws MalformedPackageURLException { |
There was a problem hiding this comment.
Please do not throw the very specific exception. My proposal would be to use a IllegalArgumentException, since the String is not fulfilling the precondition of the packageUrl parameter.
neubs-bsi
reviewed
Sep 18, 2019
| } | ||
| } | ||
|
|
||
| public static ArtifactCoordinates createArtifactCoordinates(String packageUrl) throws MalformedPackageURLException { |
There was a problem hiding this comment.
Function name is not fully clear. Unknowing developer could give any kind of string and hope for ArtifactCoordinates. Maybe add something like: fromPurl or fromPurlString
bs-ondem
force-pushed
the
bs-ondem/improve/purl
branch
from
f6eccb5 to
c848342
Compare
|
@neubs-bsi @blaumeiser-at-bosch please check my last force-push with your recommended changes. |
blaumeiser-at-bosch
approved these changes
Sep 19, 2019
Signed-off-by: Onur Demirci <Onur.Demirci@Bosch-si.com>
bs-ondem
force-pushed
the
bs-ondem/improve/purl
branch
from
c848342 to
f019abe
Compare
neubs-bsi
approved these changes
Sep 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a utility method to parse a PURL to a specific
ArtifactCoordinatesobject.