Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Initial contribution of the bespoke scheduler infrastructure for ESH #1239

Merged
merged 1 commit into from
Apr 26, 2016

Conversation

kgoderis
Copy link
Contributor

Signed-off-by: Karel Goderis karel.goderis@me.com

@kaikreuzer
Copy link
Contributor

Thanks, I have created CQ 11136 for it - waiting now for its approval.

@kaikreuzer kaikreuzer added the CQ label Mar 22, 2016
@kaikreuzer
Copy link
Contributor

@kgoderis I had some discussion with the PMC and in the end they now ask to remove the JavaDoc sections that were copied from Quartz and rather replace them by a link to the original version (e.g. http://quartz-scheduler.org/api/2.2.0/org/quartz/CronExpression.html).

Although this isn't that nice for a developer, I think it is acceptable, so I'd suggest to go for this in order to get the CQ approved. May I ask you to do this change?

@kaikreuzer
Copy link
Contributor

@kgoderis Did you see my comment above?

@kgoderis
Copy link
Contributor Author

I just did... too many emails, missing too many of these important ones .. ok will do

@kgoderis
Copy link
Contributor Author

Shall I squash after cq approval?

@kaikreuzer
Copy link
Contributor

You can squash now if you like.
Just to be sure: Was the CronExpression the only class where you copied the JavaDoc?

@kgoderis
Copy link
Contributor Author

Yep - the others are coming from the RFCs

Signed-off-by: Karel Goderis <karel.goderis@me.com>
@kaikreuzer
Copy link
Contributor

Thanks a lot, I have updated the CQ accordingly.

@kaikreuzer
Copy link
Contributor

@kgoderis Good news, the CQ has just been approved!

@kaikreuzer kaikreuzer merged commit 744f2bd into eclipse-archived:master Apr 26, 2016
@kgoderis
Copy link
Contributor Author

@kaikreuzer Cool - Time to dig up some old code. I was looking for it but could not find back where we talked about migrating org.eclipse.smarthome.model.rule and .script to use the Automation engine. I have code in place that does this migration "as is", but maybe you have ideas to overhaul the userspace rule/script pieces altogether?

@kaikreuzer
Copy link
Contributor

FTR: https://www.eclipse.org/forums/index.php?t=msg&th=1073582&goto=1719275&#msg_1719275

I have code in place that does this migration "as is", but maybe you have ideas to overhaul the userspace rule/script pieces altogether?

I think we might need both; supporting existing rules "as is" would be perfect for backward compatibility and a way that would allow us to really remove the old rule engine from the code and just use the new one.

Additionally, I would love to have a textual way to define rules for the new rule engine (since the JSON format is nice for web editors, but not nice to be written manually by users). But such a new syntax should not be specific to Xbase, but rather allow the usage of any ModuleType of the new rule engine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants