This repository has been archived by the owner on May 7, 2020. It is now read-only.
Added automatic configuration of JAXRS Connector HTTP Services base path... #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If for some reason the ConfigAdmin is not available during startup of this bundle, the setting would not work. Might it make sense to do the configuration in the RootResource (which as a component depends on ConfigurationAdmin)? |
| } | ||
|
|
||
| String rootAlias = (String) properties.get(JAXRS_CONNECTOR_PROPERTY); | ||
| if (!MDNSAnnouncer.REST_SERVLET_ALIAS.equals(rootAlias)) { |
There was a problem hiding this comment.
It might make sense to move this constant from MDNSAnnouncer to RootResource, what do you think?
There was a problem hiding this comment.
Maybe I can create a utility constants class where all the configuration constants can be stored?
…ath to /rest at rest bundle activation time. Signed-off-by: IVAN GEORGIEV ILIEV <ivan.iliev@musala.com>
kaikreuzer
added a commit
that referenced
this pull request
Jan 19, 2015
Added automatic configuration of JAXRS Connector HTTP Services base path...
danchom
pushed a commit
to danchom/smarthome
that referenced
this pull request
Oct 16, 2015
…-rules restored launch configuration with bundles for rest and script support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to /rest at rest bundle activation time.
Signed-off-by: IVAN GEORGIEV ILIEV ivan.iliev@musala.com