This repository has been archived by the owner on May 7, 2020. It is now read-only.
Improve usage of normalizer for configuration properties in Automation module. #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yordan Mihaylov <j.mihailov@prosyst.com>
|
I've changed a little bit ConfigUtil and NormalizerFactory to remove dependency to the guava lib third party lib, |
|
thanks! |
cdjackson
added a commit
to cdjackson/smarthome
that referenced
this pull request
Aug 2, 2016
* master: Initial commit of persistence extensions (eclipse-archived#1872) fixed concurrency issues (eclipse-archived#1950) Fix usage of normalizer in Automation module. (eclipse-archived#1938) changed log level for config validation (eclipse-archived#1953) Enhancement to hue binding documentation (eclipse-archived#1952) Change the hue binding to include the thing type id in the thingUID again (eclipse-archived#1946)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yordan Mihaylov j.mihailov@prosyst.com
Up to this PR only configuration properties which has number object value were normalized to BigDecimal values. Unfortunately the boolean and string objects were not changed.
Now the automation module uses NormalizerFactory to achieve Normalizer base on its config descripion parameter meta data.