Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Documentation for the trigger channels #2189

Merged
merged 6 commits into from
Sep 24, 2016
Merged

Documentation for the trigger channels #2189

merged 6 commits into from
Sep 24, 2016

Conversation

phxql
Copy link
Contributor

@phxql phxql commented Sep 19, 2016

Hi,

this PR adds the documentation for the trigger channels (which are implemented in #1936)

Signed-off-by: Moritz Kammerer <moritz.kammerer@qaware.de>
Signed-off-by: Moritz Kammerer <moritz.kammerer@qaware.de>
Signed-off-by: Moritz Kammerer <moritz.kammerer@qaware.de>
Signed-off-by: Moritz Kammerer <moritz.kammerer@qaware.de>
Signed-off-by: Moritz Kammerer <moritz.kammerer@qaware.de>
Copy link
Contributor

@maggu2810 maggu2810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't has any look at the linked PR that contains the code change, but the documentation seems to be fine -- assuming it fits to the code 😉

triggerChannel("channelId", "PRESSED")
```

The call will be delegated to the framewort. It is binding specific when the channel should be triggered.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: should be "framework"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as well.

### State channels

```
Thing yahooweather:weather:losangeles [ location="2442047", unit="us", refresh=120 ] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afair, the location must be specified without quotes by now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed all locations. They are decimal values in the binding xml:

            <parameter name="location" type="integer" required="true">

### Trigger channels

```
Thing yahooweather:weather:losangeles [ location="2442047", unit="us", refresh=120 ] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afair, the location must be specified without quotes by now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

Signed-off-by: Moritz Kammerer <moritz.kammerer@qaware.de>
@kaikreuzer
Copy link
Contributor

As the feature has been merged, we can also merge the docs for it - many thanks!

@kaikreuzer kaikreuzer merged commit 863b3d4 into eclipse-archived:master Sep 24, 2016
@phxql phxql deleted the feature/trigger-docs branch September 26, 2016 07:53
@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants