Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Renamed addons folder to extensions. Made the depedency in io.rest.co… #340

Merged
merged 1 commit into from Jun 17, 2015
Merged

Conversation

kolkoo
Copy link
Contributor

@kolkoo kolkoo commented Jun 10, 2015

…re to core.transform optional. Extracted the transformation services out of the core.transform bundle into separate ones along with their tests, the new bundles are contained within the extensions subfolder.

Signed-off-by: IVAN GEORGIEV ILIEV ivan.iliev@musala.com

…re to core.transform optional. Extracted the transformation services out of the core.transform bundle into separate ones along with their tests, the new bundles are contained within the extensions subfolder.

Signed-off-by: IVAN GEORGIEV ILIEV <ivan.iliev@musala.com>
@maggu2810
Copy link
Contributor

Hello @kolkoo
your commit contains this three changes (your commit message):

  • renamed addons folder to extensions
  • made the depedency in io.rest.core to core.transform optional
  • extracted the transformation services out of the core.transform bundle into separate ones along with their tests, the new bundles are contained within the extensions subfolder

I would like to understand that PR, so my questions:

  • Is the reanmed addons folder in any relevance to the transform changes?
  • Is the bundle separation in any relevance to the other two changes
    If I used "in relevance", I mean: does the one change depends on the other one

@kaikreuzer
Copy link
Contributor

Let me answer for @kolkoo as he did it on my request :-)

Is the reanmed addons folder in any relevance to the transform changes?

Not really, it was just because many new folders were added with all the new transform bundles. And in the whole ESH doc we talk about "extensions", that's why I felt it's a good opportunity to rename the recently added "addons" folder.

Is the bundle separation in any relevance to the other two changes

No, but it deals with the same issue: Having introduced quite some dependencies if you want to use the REST bundles (but don't want all the transform stuff like the dependency to commons-exec). This change was also a preparation for #286, which brings yet more external libraries as a dependency, so I felt it is time to separate that out to optional bundles.

@kaikreuzer
Copy link
Contributor

Created CQ 9789 as it exceeds 1000 lines. Waiting for approval.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants