Localizable and scale #349
Conversation
|
Hi @kaikreuzer , any chance to have this one reviewed and potentially merged ? Waiting for it in Netatmo Binding evolutions for OH2 |
|
Very sorry, I lost a bit track of this. Could you remind me if this had been ported from openHAB 1 and hence already been reviewed there? |
|
yes, it has been merged in OH1 |
| * input by matching it between limits of ranges in a scale file | ||
| * | ||
| * @author Gaël L'hopital | ||
| * @since 1.6.0 |
There was a problem hiding this comment.
please remove the since tag
…for scale and map Signed-off-by: Gaël L'hopital <glhopital@gmail.com> My own code review Signed-off-by: Gaël L'hopital <glhopital@gmail.com> Corrections after CR Signed-off-by: Gaël L'hopital <glhopital@gmail.com> Removing test launch files Signed-off-by: Gaël L'hopital <glhopital@gmail.com>
|
Thanks for the update! Github claims there there are merge conflicts - could you please rebase it, so that it is directly mergeable? Btw, why do you say this PR is relevant for your Netatmo binding development? In general, bindings should not have and depdendency on specific transformation services. Can you elaborate on this? |
|
To answer your question - it is not directly for the binding but for the accompagning files that I would like to provide along with the documentation. |
|
@kaikreuzer : when I try to rebase it brings back in my commit all the commits that happened since a while made by others. Can you please help ? |
|
Never mind, I have manually resolved the conflict and merged the PR :-) |
No description provided.