Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Revert JsonPath to 2.0.0, add source jars #3512

Merged
merged 1 commit into from
May 24, 2017

Conversation

htreu
Copy link
Contributor

@htreu htreu commented May 24, 2017

* Add source jars

Signed-off-by: Henning Treu <henning.treu@telekom.de>
Copy link
Contributor

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 726c727 into eclipse-archived:gh-pages May 24, 2017
@maggu2810
Copy link
Contributor

Thanks for this two changes. But one question:

Shouldn't we try to use the VCS as intended and split unrelated changes into separate commits?
Perhaps there is one, but I don't see the relationship between "add sources jars" and "downgrade JsonPath".
Or don't we care about the separation in this third-party gh-pages branch at all?

@sjsf
Copy link
Contributor

sjsf commented May 24, 2017

The relation is a bit more subtle: the pom.xml previously was updated to jsonpath-2.2.0, but the repository never was updated. Neither was the target platform. So as soon as @htreu built the new repository, it would broken the build. That's why it had to be in a single PR.

@maggu2810
Copy link
Contributor

@SJKA Okay, we have the upgrade / downgrade of the jsonpath artifact and the repository regeneration...

But how is this related to the "add <source>true</source> to the pom for every artifact to fill the repository with the sources" (I agree with that change, as we should provide the source artifact, btu I don't see the reason to mix it into one commit).

@sjsf
Copy link
Contributor

sjsf commented May 24, 2017

correct, ideally jsonpath should have been reverted first. You are right.

@htreu
Copy link
Contributor Author

htreu commented May 26, 2017

thanks for the discussion, I will keep this in mind the next time :-)

@kaikreuzer kaikreuzer modified the milestone: 0.9.0 Jun 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants