This repository has been archived by the owner on May 7, 2020. It is now read-only.
Changed logger message instantiating NPE #3888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Svilen Valkanov <svilen.valkanov@musala.com>
sjsf
suggested changes
Jul 25, 2017
There was a problem hiding this comment.
but anyway the instance here seems to be unnecessary.
Only on the first glance... This was introduced lately to find out how null values get in there. See #3521 (comment)
|
OK, I will add it as an exception then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was marked by PMD as error by the AvoidThrowingNullPointerException rule. Obviously the NPE is not thrown :), but anyway the instance here seems to be unnecessary.
Signed-off-by: Svilen Valkanov svilen.valkanov@musala.com