This repository has been archived by the owner on May 7, 2020. It is now read-only.
improve nullness handling for i18n stuff #5864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markus Rathgeb <maggu2810@gmail.com>
htreu
reviewed
Jul 5, 2018
| * constant | ||
| */ | ||
| public static String stripConstantOr(final @Nullable String key, Supplier<String> supplier) { | ||
| if (key != null && key.startsWith(CONSTANT_PATTERN)) { |
There was a problem hiding this comment.
stripConstant needs to be called with a non-null argument.
The Eclipse Nullness support we are using cannot express "if isConstant returns true the given argument is known to be non-null" (the Checker Framework can handle such cases, e.g. https://checkerframework.org/api/org/checkerframework/checker/nullness/qual/EnsuresNonNullIf.html).
The Eclipse Nullness support knows that if the check key != null in the same function has been passed, that key is non-null.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.