[mqtt] Rollershutter STOP command, outgoing transform, chained incoming transformations #6695

davidgraeff · 2018-12-18T11:08:42Z

The Rollershutter channel stores its value as percentage.
UP/DOWN/STOP commands received via MQTT do not change that state.

Instead of trying to handle those commands, they are now
posted to the framework.

Allow outgoing transformations.
Allow chained incoming transformations.
Add more examples to the readme.
Homie: Remove $stats handling
Percentage channel: Return value between min/max instead of 0..100.

Signed-off-by: David Gräff david.graeff@web.de

kaikreuzer · 2018-12-18T15:39:41Z

...main/java/org/eclipse/smarthome/binding/mqtt/generic/internal/values/RollershutterValue.java

- return;
- }
- state = newState;
+ throw new IllegalStateException("Cannot call update() with UpDownType");


Why? UpDownType implements State, so updates are valid (and correspond to 0 and 100).

So they are not meant to be move commands like "move up", "move down" but more like states meaning "completely up" and "completely down"?
A user wrote me a pm saying that stop doesn't work for him (which is absolutely correct) and that up/down sends his rollershutters up/down (which is correct so far) but also updates the state to 0% and 100% which he was not expecting.

Yes, the commands UP/DOWN mean that it should move to UP (=0) or DOWN (=100) position.

also updates the state to 0% and 100%

The binding itself should indeed not update the state, but by default the "autoupdate" feature of the framework does it - if it sees an UP event, it will do a state auto-update to 0%.

Note that since #5011, the binding can define an auto-update policy, so you can actually configure channels in a way that the framework suppresses the auto-update behavior. This is probably what should usually be done for rollershutters as the state is reached much later than the command has been received, so the state update should better come from the physical device.

@davidgraeff What's the status here now? Are you waiting for anything from my side?

I have changed the code already and was waiting for another review. Have no time for the rebase right now though.

I cannot see any code change, this is why I was asking. The line that I commented still throws an IllegalStateException...

Ah ok, must have overlooked that line. When I do the rebase, I'll look into it again :)

Any news here?

I have added some changes

openhab-bot · 2018-12-19T18:41:37Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/mqtt-2-5/60365/1

openhab-bot · 2018-12-27T17:31:25Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/binding-mqtt-2-5-0-snapshot-rollershutter-command-is-sent-wrong/61091/5

openhab-bot · 2018-12-27T18:19:24Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/mqtt2-in-openhab-2-4-rollershutter-map/61311/5

openhab-bot · 2018-12-27T18:24:33Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/mqtt2-in-openhab-2-4-rollershutter-map/61311/5

kaikreuzer · 2019-01-11T12:28:14Z

@davidgraeff Could you please check the compilation failures on Travis?

davidgraeff · 2019-01-11T12:31:19Z

Yes of course.

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:1.2.0:compile (default-compile) on project org.eclipse.smarthome.binding.mqtt.generic.test: Compilation failure: Compilation failure: 
[ERROR] /home/travis/build/eclipse/smarthome/extensions/binding/org.eclipse.smarthome.binding.mqtt.generic.test/src/test/java/org/eclipse/smarthome/binding/mqtt/generic/internal/values/ValueTests.java:[86] 
[ERROR] 	PercentageValue v = new PercentageValue(null, null, null);
[ERROR] 	                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The constructor PercentageValue(null, null, null) is undefined
[ERROR] /home/travis/build/eclipse/smarthome/extensions/binding/org.eclipse.smarthome.binding.mqtt.generic.test/src/test/java/org/eclipse/smarthome/binding/mqtt/generic/internal/values/ValueTests.java:[98] 
[ERROR] 	PercentageValue v = new PercentageValue(null, null, null);
[ERROR] 	                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The constructor PercentageValue(null, null, null) is undefined
[ERROR] /home/travis/build/eclipse/smarthome/extensions/binding/org.eclipse.smarthome.binding.mqtt.generic.test/src/test/java/org/eclipse/smarthome/binding/mqtt/generic/internal/values/ValueTests.java:[183] 
[ERROR] 	PercentageValue v = new PercentageValue(new BigDecimal(10.0), new BigDecimal(110.0), new BigDecimal(1.0));
[ERROR] 	                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The constructor PercentageValue(BigDecimal, BigDecimal, BigDecimal) is undefined
[ERROR] /home/travis/build/eclipse/smarthome/extensions/binding/org.eclipse.smarthome.binding.mqtt.generic.test/src/test/java/org/eclipse/smarthome/binding/mqtt/generic/internal/values/ValueTests.java:[192] 
[ERROR] 	PercentageValue v = new PercentageValue(new BigDecimal(0.1), new BigDecimal(1.0), new BigDecimal(0.1));
[ERROR] 	                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The constructor PercentageValue(BigDecimal, BigDecimal, BigDecimal) is undefined
[ERROR] /home/travis/build/eclipse/smarthome/extensions/binding/org.eclipse.smarthome.binding.mqtt.generic.test/src/test/java/org/eclipse/smarthome/binding/mqtt/generic/internal/values/ValueTests.java:[203] 
[ERROR] 	PercentageValue v = new PercentageValue(new BigDecimal(10.0), new BigDecimal(110.0), new BigDecimal(1.0));
[ERROR] 	                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The constructor PercentageValue(BigDecimal, BigDecimal, BigDecimal) is undefined
[ERROR] /home/travis/build/eclipse/smarthome/extensions/binding/org.eclipse.smarthome.binding.mqtt.generic.test/src/test/java/org/eclipse/smarthome/binding/mqtt/generic/internal/generic/ChannelStateTests.java:[195] 
[ERROR] 	PercentageValue value = new PercentageValue(new BigDecimal(-100), new BigDecimal(100), new BigDecimal(10));
[ERROR] 	                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The constructor PercentageValue(BigDecimal, BigDecimal, BigDecimal) is undefined
[ERROR] /home/travis/build/eclipse/smarthome/extensions/binding/org.eclipse.smarthome.binding.mqtt.generic.test/src/test/java/org/eclipse/smarthome/binding/mqtt/generic/internal/generic/ChannelStateTransformationTests.java:[109] 
[ERROR] 	assertThat(channelConfig.transformations.get(0).pattern, is(jsonPathPattern));
[ERROR] 	                         ^^^^^^^^^^^^^^^
[ERROR] transformations cannot be resolved or is not a field
[ERROR] /home/travis/build/eclipse/smarthome/extensions/binding/org.eclipse.smarthome.binding.mqtt.generic.test/src/test/java/org/eclipse/smarthome/binding/mqtt/generic/internal/generic/ChannelStateTransformationTests.java:[121] 
[ERROR] 	ChannelStateTransformation transformation = channelConfig.transformations.get(0);
[ERROR] 	                                                          ^^^^^^^^^^^^^^^

kaikreuzer · 2019-01-14T08:00:37Z

@davidgraeff I "saw" them myself, my request was rather to fix them...

davidgraeff · 2019-01-14T11:23:45Z

I'm sure you saw them. That was my way of avoiding to lookup travis again for a later fix.

openhab-bot · 2019-01-17T12:26:36Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/mqtt-2-5/60365/12

The Rollershutter channel stores its value as percentage. UP/DOWN/STOP commands received via MQTT do not change that state. Instead of trying to handle those commands, they are now posted to the framework. * Allow outgoing transformations. * Allow chained incoming transformations. * Add more examples to the readme. Signed-off-by: David Gräff <david.graeff@web.de>

…ndling completely. Readme: Add retain and isCommand and some more mqtt1 details. Rollershutter: Fix Signed-off-by: David Graeff <david.graeff@web.de>

… min/max

davidgraeff · 2019-01-17T16:06:36Z

@kaikreuzer All tests fixed

kaikreuzer

Thanks!

openhab-bot · 2019-11-04T12:32:47Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/mqtt-2-chained-transformations/84861/4

davidgraeff force-pushed the mqttrollershutter branch from 6739a16 to f461364 Compare December 18, 2018 11:09

kaikreuzer added the Binding-MQTT label Dec 18, 2018

kaikreuzer suggested changes Dec 18, 2018

View reviewed changes

davidgraeff force-pushed the mqttrollershutter branch 2 times, most recently from 96de2c6 to ea345ef Compare December 19, 2018 18:28

davidgraeff changed the title ~~MQTT: Rollershutter channel. Proper STOP command support.~~ MQTT: Rollershutter STOP command, outgoing transform, chained incoming transformations. Dec 19, 2018

davidgraeff force-pushed the mqttrollershutter branch from ea345ef to 0f22534 Compare December 19, 2018 18:52

davidgraeff mentioned this pull request Dec 19, 2018

STOP Commands on rollershuter node tobof/openhab-addons#132

Closed

davidgraeff force-pushed the mqttrollershutter branch from 0f22534 to 0c153b3 Compare January 11, 2019 11:00

kaikreuzer approved these changes Jan 11, 2019

View reviewed changes

kaikreuzer changed the title ~~MQTT: Rollershutter STOP command, outgoing transform, chained incoming transformations.~~ [mqtt] Rollershutter STOP command, outgoing transform, chained incoming transformations Jan 11, 2019

kaikreuzer added the enhancement label Jan 11, 2019

David Gräff added 3 commits January 17, 2019 14:48

PercentageChannel: Return value between min and max. Homie: Remove ha…

8da0bb0

…ndling completely. Readme: Add retain and isCommand and some more mqtt1 details. Rollershutter: Fix Signed-off-by: David Graeff <david.graeff@web.de>

Fix tests. Add more tests for percentageValue. NumberValue: Check for…

561fe5b

… min/max

davidgraeff force-pushed the mqttrollershutter branch from 4e12a8b to 561fe5b Compare January 17, 2019 13:49

kaikreuzer approved these changes Jan 18, 2019

View reviewed changes

kaikreuzer merged commit d739f6a into eclipse-archived:master Jan 18, 2019

davidgraeff deleted the mqttrollershutter branch January 18, 2019 08:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[mqtt] Rollershutter STOP command, outgoing transform, chained incoming transformations #6695

[mqtt] Rollershutter STOP command, outgoing transform, chained incoming transformations #6695

davidgraeff commented Dec 18, 2018 •

edited

Loading

kaikreuzer Dec 18, 2018

davidgraeff Dec 18, 2018

kaikreuzer Dec 19, 2018

kaikreuzer Jan 1, 2019

davidgraeff Jan 2, 2019

kaikreuzer Jan 2, 2019

davidgraeff Jan 2, 2019

kaikreuzer Jan 11, 2019

davidgraeff Jan 11, 2019

openhab-bot commented Dec 19, 2018

openhab-bot commented Dec 27, 2018

openhab-bot commented Dec 27, 2018

openhab-bot commented Dec 27, 2018

kaikreuzer commented Jan 11, 2019

davidgraeff commented Jan 11, 2019

kaikreuzer commented Jan 14, 2019

davidgraeff commented Jan 14, 2019

openhab-bot commented Jan 17, 2019

davidgraeff commented Jan 17, 2019

kaikreuzer left a comment

openhab-bot commented Nov 4, 2019

[mqtt] Rollershutter STOP command, outgoing transform, chained incoming transformations #6695

[mqtt] Rollershutter STOP command, outgoing transform, chained incoming transformations #6695

Conversation

davidgraeff commented Dec 18, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openhab-bot commented Dec 19, 2018

openhab-bot commented Dec 27, 2018

openhab-bot commented Dec 27, 2018

openhab-bot commented Dec 27, 2018

kaikreuzer commented Jan 11, 2019

davidgraeff commented Jan 11, 2019

kaikreuzer commented Jan 14, 2019

davidgraeff commented Jan 14, 2019

openhab-bot commented Jan 17, 2019

davidgraeff commented Jan 17, 2019

kaikreuzer left a comment

Choose a reason for hiding this comment

openhab-bot commented Nov 4, 2019

davidgraeff commented Dec 18, 2018 •

edited

Loading