Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #366085 concerning declared annotations with source retention #196

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

kriegaex
Copy link
Contributor

@kriegaex kriegaex commented Dec 4, 2022

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=366085.
See https://stackoverflow.com/q/74618269/1082681.

The issue described in the Bugzilla issue is about declare @type, but similar issues also existed for declare @field, declare @method, declare @constructor. This fix is rather superficial and leaves things to be desired, because it is rather hacky and simply ignores errors source retention annotation declarations during weaving. A better fix would drop the corresponding declarations while parsing and also issue compiler warnings in each case.

@aclement, please do take some time to review this PR, before I merge in into the java-19 branch. Sorry for not creating a separate branch against master in this case, but in the Java 19 branch I already have the infrastructure for new tests and could just easily add it one more test case. By all means, if you can come up with a better way of solving this, I will be happy to drop this commit. You may also commit on top of this PR, if you choose to do so - whatever suits your needs.

@kriegaex kriegaex added the bug Something isn't working label Dec 4, 2022
@kriegaex kriegaex added this to the 1.9.19 milestone Dec 4, 2022
@kriegaex kriegaex requested a review from aclement December 4, 2022 15:22
@kriegaex kriegaex self-assigned this Dec 4, 2022
@kriegaex
Copy link
Contributor Author

kriegaex commented Dec 4, 2022

I have started a manual build and test run for this PR branch here, because the PR is not against master and an automatic build is therefore not being triggered:

https://github.com/eclipse/org.aspectj/actions/runs/3614083565

Build AspectJ

Base automatically changed from java-19 to master December 21, 2022 12:40
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=366085.
See https://stackoverflow.com/q/74618269/1082681.

The issue described in the Bugzilla issue is about 'declare @type', but
similar issues also existed for 'declare @field', 'declare @method',
'declare @constructor'. This fix is rather superficial and leaves
things to be desired, because it is rather hacky and simply ignores
errors source retention annotation declarations during weaving. A better
fix would drop the corresponding declarations while parsing and also
issue compiler warnings in each case.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant