-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve query parameter for switching between AAS Viewer/Editor and Submodel Viewer #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…model Viewer, About page, ... Fixes eclipse-basyx#166
seicke
changed the title
Preserve query parameter for switching between AAS Viewer/Editor, Submodel Viewer, About page, ...
Preserve query parameter for switching between AAS Viewer/Editor and Submodel Viewer
Jan 6, 2025
aaronzi
requested changes
Jan 8, 2025
aaronzi
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserving of query parameter was realised with route guard in combination with a new query state in the navigation store.
route.ts
the order ofapp.use(pinia)
andapp.use(router)
inmain.ts
had to be adapted.Fetching and dispatching of AAS was already outsourced in the AAS repository client and could be used easily. An equivalent function for fetching and dispatching of SME has been missing so far and was implemented in SMRepositoryClient.
This PR also adapted
App.vue
regarding the usage of the new functionalityfetchAndDispatchSme()
to simplify code readability.Closes #166