Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve query parameter for switching between AAS Viewer/Editor and Submodel Viewer #199

Merged
merged 12 commits into from
Jan 9, 2025

Conversation

seicke
Copy link
Member

@seicke seicke commented Jan 5, 2025

Preserving of query parameter was realised with route guard in combination with a new query state in the navigation store.

  • To use the navigation store in the route.ts the order of app.use(pinia) and app.use(router) in main.ts had to be adapted.
  • Within the route guard it is necessary to fetch and dispatch the AAS/SME with respect to the preserved query parameter.

Fetching and dispatching of AAS was already outsourced in the AAS repository client and could be used easily. An equivalent function for fetching and dispatching of SME has been missing so far and was implemented in SMRepositoryClient.

This PR also adapted App.vue regarding the usage of the new functionality fetchAndDispatchSme() to simplify code readability.

Closes #166

@seicke seicke marked this pull request as draft January 5, 2025 19:16
@seicke seicke marked this pull request as ready for review January 6, 2025 05:21
@seicke seicke requested a review from aaronzi January 6, 2025 05:22
@seicke seicke marked this pull request as draft January 6, 2025 09:17
@seicke seicke marked this pull request as ready for review January 6, 2025 14:30
@seicke seicke changed the title Preserve query parameter for switching between AAS Viewer/Editor, Submodel Viewer, About page, ... Preserve query parameter for switching between AAS Viewer/Editor and Submodel Viewer Jan 6, 2025
aas-web-ui/src/router.ts Outdated Show resolved Hide resolved
aas-web-ui/src/App.vue Show resolved Hide resolved
@seicke seicke marked this pull request as draft January 8, 2025 15:01
@seicke seicke marked this pull request as ready for review January 9, 2025 03:25
@seicke seicke requested a review from aaronzi January 9, 2025 03:25
@aaronzi aaronzi merged commit dc8ad40 into eclipse-basyx:main Jan 9, 2025
2 checks passed
@seicke seicke deleted the seicke/issue166 branch January 9, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Preserve query parameter for switching between AAS Editor / AAS Viewer / About Page
2 participants