Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to non-BIRT bundles from features #1794

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

merks
Copy link
Contributor

@merks merks commented Jul 15, 2024

  • Use jgit timestamp provider for product qualifiers.
  • Add org.apache.batik.ext.awt.image.codec.imageio where org.apache.batik.transcoder.image is used.
  • Reduce the content of the all-in-one product, mostly to remove redundant includes.
  • Ensure the runtime product is complete enough after the features have been simplified such tha the OSGi runtime test still works.

- Use jgit timestamp provider for product qualifiers.
- Add org.apache.batik.ext.awt.image.codec.imageio where
org.apache.batik.transcoder.image is used.
- Reduce the content of the all-in-one product, mostly to remove
redundant includes.
- Ensure the runtime product is complete enough after the features have
been simplified such tha the OSGi runtime test still works.
@merks
Copy link
Contributor Author

merks commented Jul 15, 2024

@wimjongman @speckyspooky

Guys, this change effectively removes all references to 3rd party bundles as well as references to all bundles and feature from other projects from BIRT's features. This ensures that BIRT does not lock in any specific versions. The requires of bundles are sufficient to ensure that the necessary requirements are installed.

Also, with this change, I think using the jgit timestamp provider will be an improvement, i.e., builds will produce a new version of a bundle only when there is a commit to the bundle and for features only if there is a commit to anything included bundle or feature included the feature (which is now only other BIRT bundles and features). Most projects are using the jgit timestamp provider to avoid producing all new artifacts with each build.

Do you have any concerns?

@speckyspooky
Copy link
Contributor

Yes, I confirm your changes, It sounds good and also your test results.
So each shrink of the all-in-one-product ist welcome.

@merks merks merged commit 37da6d1 into eclipse-birt:master Jul 16, 2024
3 checks passed
@merks merks deleted the pr-simplify-features-and-products branch July 16, 2024 07:11
@wimjongman
Copy link
Contributor

Thank you, Ed! Brilliant.

@speckyspooky speckyspooky added this to the 4.17 milestone Jul 16, 2024
@speckyspooky speckyspooky added the Dependencies Pull requests that update a dependency file label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants