Update address only for newest tls12_cid records. #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boaks
force-pushed
the
fix_address_update
branch
2 times, most recently
from
8bba4a0
to
c92949f
Compare
This was referenced Jul 15, 2019
boaks
force-pushed
the
fix_address_update
branch
from
c92949f
to
dcf8b8d
Compare
boaks
force-pushed
the
fix_address_update
branch
from
dcf8b8d
to
f388140
Compare
boaks
force-pushed
the
fix_address_update
branch
from
f388140
to
f811e71
Compare
|
I've updated the implementation, because There is one issue left: |
boaks
force-pushed
the
fix_address_update
branch
from
f811e71
to
773d8e3
Compare
|
In the meantime, I think, that this requires a extension of the test NAT to explicitly reorder and delay messages to verify the function. But not before the weekend, so this will come next week :-). |
boaks
force-pushed
the
fix_address_update
branch
2 times, most recently
from
3b64194
to
cc7c2cf
Compare
Considering message reordering, it can't be distinguished, if the address of an older record, which is received delayed, has a more up-to-date address or not. Signed-off-by: Achim Kraus <achim.kraus@bosch-si.com>
boaks
force-pushed
the
fix_address_update
branch
from
cc7c2cf
to
4cb83c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix updates with already deprecated addresses.
Signed-off-by: Achim Kraus achim.kraus@bosch-si.com