Adapt javadoc of CertificateVerifier. #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See issue #1245 |
sbernard31
approved these changes
Mar 18, 2020
| @@ -42,7 +42,11 @@ | |||
| * Return an array of certificate authority certificates which are trusted | |||
| * for authenticating peers. | |||
| * | |||
| * @return the trusted CA certificates (possibly <code>null</code>) | |||
| * The javadoc of previous versions (2.1.0 and before) permits to use | |||
| * {@code null}. This causes an failure, please adapt to use an empty array. | |||
There was a problem hiding this comment.
Suggested change
| * {@code null}. This causes an failure, please adapt to use an empty array. | |
| * {@code null}. This causes a failure, please adapt to use an empty array. |
Suppport only "empty array" for issuers. null is considered to be valid return value. Signed-off-by: Achim Kraus <achim.kraus@bosch.io>
boaks
force-pushed
the
change_javadoc_certificate_verifier
branch
from
c53e72f to
b5b5c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppport only "empty array" for issuers.
null is considered to be valid return value.
Signed-off-by: Achim Kraus achim.kraus@bosch.io