Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter "properties" in model "Trace" #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

siwei-zhang-work
Copy link

@siwei-zhang-work siwei-zhang-work commented Sep 23, 2024

Add the parameter "properties" introduced by commit 499408e3979cab403a5d58 in the server (incubator).

Link to the PR for the commit: eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#79

Add the parameter "properties" introduced by commit 499408e3979cab403a5d58

Signed-off-by: Siwei Zhang <siwei.zhang@ericsson.com>
@marcdumais-work
Copy link
Contributor

marcdumais-work commented Sep 23, 2024

Note: the license check CI workflow is currently failing in most of our cdt.cloud repos, on dependency npm/npmjs/-/electron-to-chromium/1.5.13. We believe it's a false-positive.

Eclipse Foundation IP ticket:
https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/16197

@marcdumais-work
Copy link
Contributor

@bhufmann We are getting that same 3PP license check failure in many of our repos now (for dependency electron-to-chromium/1.5.13 - see previous comment on this PR). The IP ticket is still under review - it might be closed today or two weeks from now, no way to know. I see two options:

  • add the dependency in question to the license check ignore list, in any/all repos where the failure happens
  • ignore license check failures, but only if/when only this specific dependency is the cause of the failure.

WDYT?

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this contribution!

The corresponding TC incubator PR is still under review but has 1 approval already, so it looks like it will be merged. The second approval for this PR here should be a TC committer, that will have the complete view on this.

There is also the matter of the failed license check workflow, for reasons unrelated to this PR, that we need to decide what to do about.
Discussed with Bernd and the team - we would be ok to merge with the failed check in that case (see above), if the IP ticket has not yet been approved by the time we have the 2 approvals for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants