Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import memory window is not working as expected #449

Closed
Cosminbyc opened this issue Jul 7, 2023 · 2 comments · Fixed by #450
Closed

Import memory window is not working as expected #449

Cosminbyc opened this issue Jul 7, 2023 · 2 comments · Fixed by #450
Assignees
@ruspl-afed

Comments

@Cosminbyc
Copy link

Describe the bug
When click on "Browse" button from "Import memory" window for Plain Text, RAW Binary and SRecord format, it opens "Choose memory import file" window with "Save" button and a "Confirm save as" pop-up.

Expected behavior
"Save" button should be replaced with "Open" button and when click "Open" button to not show "Confirm save as" pop-up.

Screenshots
import

Confirm_save_as

Desktop (please complete the following information):

  • OS: Windows 10

Build Identifier:

  • Eclipse version: 2021-06 (4.20.0)
  • Build id: 20210612-2011
@jonahgraham
Copy link
Member

Thanks @Cosminbyc for the report.

@ruspl-afed I was wondering if you had time to look at this issue because IIRC you recently(ish) were working in this area of code.

ruspl-afed added a commit to ruspl-afed/cdt that referenced this issue Jul 7, 2023
@ruspl-afed
[eclipse-cdt#449] Import memory window is not working as expected
e715179 
Use `SWT.OPEN` style for import dialogs

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
ruspl-afed added a commit to ruspl-afed/cdt that referenced this issue Jul 7, 2023
@ruspl-afed
[eclipse-cdt#449] Import memory window is not working as expected
1710aa2 
Increment version for org.eclipse.cdt.debug.ui.memory.transport

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
@ruspl-afed
Copy link
Member

The error seems to be so old that it could be called a feature. Please have a look at #450 @jonahgraham

@ruspl-afed ruspl-afed self-assigned this Jul 7, 2023
@ruspl-afed ruspl-afed mentioned this issue Jul 8, 2023
Merged
ruspl-afed added a commit that referenced this issue Jul 8, 2023
@ruspl-afed
[#449] Import memory window is not working as expected
68ccd09 
Use `SWT.OPEN` style for import dialogs

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
ruspl-afed added a commit that referenced this issue Jul 8, 2023
@ruspl-afed
[#449] Import memory window is not working as expected
c23b324 
Increment version for org.eclipse.cdt.debug.ui.memory.transport

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruspl-afed ruspl-afed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#449] Import memory window is not working as expected ruspl-afed/cdt
3 participants
@jonahgraham @ruspl-afed @Cosminbyc