Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: CMakePropertyPage_LaunchCMakeGui opens cmake-gui with wrong source path #532

Closed
gravemalte opened this issue Aug 31, 2023 · 0 comments · Fixed by #533
Closed

CMake: CMakePropertyPage_LaunchCMakeGui opens cmake-gui with wrong source path #532

gravemalte opened this issue Aug 31, 2023 · 0 comments · Fixed by #533

Comments

@gravemalte
Copy link
Contributor

gravemalte commented Aug 31, 2023 •
edited
Loading

Describe the bug
When opening the project properties in a CMake project and selecting the Launch CMake GUI button, cmake-gui is launching but with the wrong source path.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to 'Properties -> CMake'
  2. Click on 'Launch CMake GUI'
  3. Observe the wrong source path

Expected behaviour
The expected source path should be the project source path

Version Information (please complete the following information):

  • OS -> Linux 6.2.x Arch derivate
  • Eclipse Version from Help -> About 2023-09, M3
  • CDT Version -> Latest build from main

Solution

In org.eclipse.cdt.cmake.internal.ui.properties.CMakePropertyPage on line number 137, the -H flag is set to the new cmake-gui process. But -H is the help flag for CMake. The correct flag is -S [0].

Refs: [0] https://cmake.org/cmake/help/latest/manual/cmake-gui.1.html#options

I will open up a PR, this is a tiny fix.
@gravemalte gravemalte mentioned this issue Aug 31, 2023
Merged
davmac314 pushed a commit to davmac314/cdt that referenced this issue Sep 24, 2023
@gravemalte @davmac314
CMake: Fixed the correct path for starting 'cmake-gui'
adf5749 
This PR fixed the wrong source flag which was set by spawning the cmake-gui command.

Closes eclipse-cdt#532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CMake: Fixed the correct path for starting 'cmake-gui' gravemalte/cdt
1 participant
@gravemalte