Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Managed Build Definitions extension point should prefer "identifier" type of attribute #592

Closed
ruspl-afed opened this issue Oct 11, 2023 · 2 comments
Closed

Managed Build Definitions extension point should prefer "identifier" type of attribute #592

ruspl-afed opened this issue Oct 11, 2023 · 2 comments
Assignees
@ruspl-afed

Comments

@ruspl-afed
Copy link
Member

Describe the bug
Currently fields like superClass has type string and this is not helpful to specify the right value

To Reproduce
Steps to reproduce the behavior:

  1. Try to define new extension for "org.eclipse.cdt.managedbuilder.core.buildDefinitions" extension point
  2. Add ToolChain
  3. Try to specify superClass value

Expected behavior
Fields that expect identifiers suggest them from the list of existing values
ruspl-afed added a commit to ruspl-afed/cdt that referenced this issue Oct 11, 2023
@ruspl-afed
[eclipse-cdt#592] Managed Build Definitions : prefer "identifier" typ…
5eae802 
…e of attribute

Add meta information for id-like attributes

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
ruspl-afed added a commit that referenced this issue Oct 11, 2023
@ruspl-afed
[#592] Managed Build Definitions : prefer "identifier" type of attribute
7136606 
Add meta information for id-like attributes

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
ruspl-afed added a commit to ruspl-afed/cdt that referenced this issue Oct 11, 2023
@ruspl-afed
Revert "[eclipse-cdt#592] Managed Build Definitions : prefer "identif…
af3302c 
…ier" type of attribute"

This reverts commit 7136606.
ruspl-afed added a commit that referenced this issue Oct 11, 2023
@ruspl-afed
Revert "[#592] Managed Build Definitions : prefer "identifier" type o…
b0317c0 
…f attribute"

This reverts commit 7136606.
@ruspl-afed
Copy link
Member Author

Yes, it is easy to implement this for top-level entries, but we have a lot of others, like ToolChain inside Configuration.

So, it seems that I need to introduce id metadata not "by schema", but rather "by entity", to check result after each minor step.

@ruspl-afed ruspl-afed self-assigned this Oct 11, 2023
@ruspl-afed
Copy link
Member Author

I'm afraid this is not possible to implement as identifiers may come from dynamic extension and we cannot determine the whole list of possible identifiers in PDE static context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruspl-afed ruspl-afed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ruspl-afed