Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[releng] Fix up usages of tycho-source-plugin #104

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

mbooth101
Copy link
Member

Currently you can see this warning about migrating to the new feature-source goal:

[INFO] --- tycho-source-feature-plugin:2.7.5:source-feature (source-feature) @ org.eclipse.cdt.testing ---
[WARNING] Mojo tycho-source-feature-plugin:source-feature is replaced by the tycho-source-plugin:feature-source which offers equivalent and even enhanced functionality

And you can see duplicate invokations of the plugin-source goal:

[INFO] --- tycho-source-plugin:2.7.5:plugin-source (plugin-source) @ org.eclipse.cdt.platform.branding ---
[INFO] Building jar: /home/mbooth/workspace-cdt/org.eclipse.cdt/releng/org.eclipse.cdt.platform.branding/target/org.eclipse.cdt.platform.branding-11.0.0-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- tycho-source-plugin:2.7.5:plugin-source (attach-source) @ org.eclipse.cdt.platform.branding ---
[INFO] Building jar: /home/mbooth/workspace-cdt/org.eclipse.cdt/releng/org.eclipse.cdt.platform.branding/target/org.eclipse.cdt.platform.branding-11.0.0-SNAPSHOT-sources.jar

This change fixes both problems and will ease eventual migration to tycho 3.

@mbooth101 mbooth101 requested a review from akurtakov October 16, 2022 15:33
@github-actions
Copy link

github-actions bot commented Oct 16, 2022

Test Results

     612 files       612 suites   17m 7s ⏱️
10 253 tests 10 230 ✔️ 21 💤 2
10 216 runs  10 193 ✔️ 21 💤 2

For more details on these failures, see this check.

Results for commit c93377e.

♻️ This comment has been updated with latest results.

Migrate usage of deprecated tycho-source-feature-plugin plugin
to the tycho-source-plugin:feature-source goal.

Eliminate duplicate invokations of the
tycho-source-plugin:plugin-source goal.
@akurtakov
Copy link
Contributor

GH action fails but jenkins job succeeds so I think it's not issue with the patch, which is otherwise good.

@akurtakov akurtakov merged commit 95fb6ee into eclipse-cdt:main Oct 17, 2022
@mbooth101 mbooth101 deleted the feature_source branch October 17, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants