Improve the CMake project wizard template #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hello world CMake project template is extremely basic and generates deprecation warnings out-of-the-box:
And will not build at all if you name the project something containing a space:
Every currently supported distro of Linux that I checked comes with CMake > 3 so I propose we make the template a bit better. This change fixes the deprecation warnings by bumping the min version of CMake to 3.10 (still a very old version) and takes advantage of some features from CMake > 3, like showing how to set some project configuration details, and showing how to implement the common idiom of generating configuration headers.
Project names containing spaces is also allowed by this patch by using freemarker syntax to remove them where necessary in the template.