Add ManagedBuildManager#createConfigurationForProject() #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow ISV's to create MBS based project with a vendor-specific build-system ID without using internal API. Signed-off-by: 15knots <11367029+15knots@users.noreply.github.com>
|
Sorry, forgat the N&N.... Coming soon. |
Signed-off-by: 15knots <11367029+15knots@users.noreply.github.com>
Signed-off-by: 15knots <11367029+15knots@users.noreply.github.com>
mbooth101
reviewed
Nov 3, 2022
|
|
||
| IConfiguration config = ManagedBuildManager.createConfigurationForProject(des, mProj, cf, | ||
| ManagedBuildManager.CFG_DATA_PROVIDER_ID); | ||
| // TODO check config.exportArtifactInfo(); |
There was a problem hiding this comment.
Looks like this call to exportArtifactInfo() was moved to createConfigurationForProject()
What is TODO here?
There was a problem hiding this comment.
Forgot to delete that. It is a reminder to check whether the refactored code should call 'config.exportArtifactInfo();'.
jonahgraham
reviewed
Nov 4, 2022
There was a problem hiding this comment.
LGTM - Thanks for recreating a clean commit. Thanks @mbooth101 for doing a review too.
Signed-off-by: 15knots <11367029+15knots@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow ISV's to create MBS based project with a vendor-specific build-system ID without using internal API.
Signed-off-by: 15knots 11367029+15knots@users.noreply.github.com