Handle invalid empty c++17 fold expression early #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgraham
approved these changes
Mar 16, 2023
One of Qt sample snippets contain (...) as placeholder for actual user code. Parsing that leads to invalid class cast because buildExpression would return fold expression token marker and not a proper ICPPASTexpression. Fix that by handling this error early as invalid fold expression.
|
I have rebased the change to make sure that it builds cleanly on main now that we released 11.1.0. Normally this is just a check that code cleanliness still passes, especially bundle version numbers are where they are supposed to be. |
jonahgraham
force-pushed
the
pr/c++17-fold-expression-handle-invalid-empty-fold-early
branch
from
acb5508 to
203559a
Compare
i-garrison
deleted the
pr/c++17-fold-expression-handle-invalid-empty-fold-early
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of Qt sample snippets contain
(...)as placeholder for actual user code. Parsing that leads to invalid class cast because buildExpression would return fold expression token marker and not a proper ICPPASTexpression.Fix that by handling this error early as invalid fold expression.