Handle null "DisplayName" in registry #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jld01 please let me know what you think, and if there is anywhere else this may need to be fixed too. Should we spin up a 11.1.1 release to include this? |
jld01
approved these changes
Mar 19, 2023
|
Should we spin up a 11.1.1 release to include this? |
The workaround is undesirable and error-prone, so a bugfix release seems highly desirable to me. |
|
+1 |
jonahgraham
added a commit
to jonahgraham/cdt
that referenced
this pull request
Mar 20, 2023
This is a backport of 0dabaa1 from PR eclipse-cdt#331 Fixes eclipse-cdt#330
jonahgraham
added a commit
to jonahgraham/cdt
that referenced
this pull request
Mar 20, 2023
This is a backport of 0dabaa1 from PR eclipse-cdt#331 Fixes eclipse-cdt#330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330