Enable toggling breakpoints in LSP CEditor #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an example of where we have somewhat an inversion of dependencies. The existing CDT code assumes it knows about all types of editors at compile time. In this case the LSP C Editor is a new type. However, rather than creating a new extension mechanism here we are simply adding the LSP C Editor to the known list as the LSP C Editor is (or will soon be) part of CDT itself anyway (see eclipse-cdt#354) By itself this change doesn't do anything, it needs the change in eclipse-cdt/cdt-lsp#46 Also-by: Gesa HENTSCHKE <Gesa.HENTSCHKE@bachmann.info>
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of where we have somewhat an inversion of dependencies. The existing CDT code assumes it knows about all types of editors at compile time. In this case the LSP C Editor is a new type. However, rather than creating a new extension mechanism here we are simply adding the LSP C Editor to the known list as the LSP C Editor is (or will soon be) part of CDT itself anyway (see #354)
By itself this change doesn't do anything, it needs the change in eclipse-cdt/cdt-lsp#46
Also-by: Gesa HENTSCHKE Gesa.HENTSCHKE@bachmann.info