Bug 580259: Not all remote session have a connected process #49
Conversation
Contributed by STMicroelectronics Change-Id: I21f9cc095e7a4f6ba0af4ef344e74fdbe8f6c43a Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
|
Imported from https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/194819 |
|
@jonahgraham: Should we consider the last comment on https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/188851 or should we simply go with this solution? |
|
I can't properly review this now, nor answer your question. That said Umair has demonstrated good knowledge in this area in the past. I can look again in a few days. |
|
Essentially cherry-picked from 96839a0 |
| @@ -333,38 +327,38 @@ public void attachDebuggerToProcess(final IProcessDMContext procCtx, final Strin | |||
| public void execute(final RequestMonitor rm) { | |||
| // The remote session is already connected to the process | |||
| // Bug 528145 | |||
| if (fBackend.getSessionType() == SessionType.REMOTE) { | |||
| if (fBackend.getSessionType() == SessionType.REMOTE | |||
| && doCanDetachDebuggerFromProcess()) { | |||
There was a problem hiding this comment.
I am unable to understand the reason for this condition..
I am running multi-gdbserver and attaching to second process using GdbConnectCommand and because of this condition, actual attach is not happening.. am I missing something here?
There was a problem hiding this comment.
@umairsair can you raise a new issue for this please so we can get it tested and resolved.
There was a problem hiding this comment.
@jonahgraham I'll try to work on it in detail and will submit a patch if there is really an issue on CDT side and not something in my local setup..
|
|
||
| if (numConnected == 1 && sessionType == SessionType.REMOTE) { | ||
| // Bug 528145: Special case for remote sessions with an existing connection. | ||
| return true; |
There was a problem hiding this comment.
Because of this change, connect option is always available in context menu of debug session even for all-stop mode but debug new executable is grayed out.. I am using "C/C++ Attach to Application" with "gdbserver" as debugger..
I'll further look into https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/188851
Contributed by STMicroelectronics
Change-Id: I21f9cc095e7a4f6ba0af4ef344e74fdbe8f6c43a
Signed-off-by: Torbjörn Svensson torbjorn.svensson@st.com