Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend list initialization sequence #581

Merged

Conversation

i-garrison
Copy link
Contributor

  • add more tests for list-initialization of class or aggregate
  • amend list-initialization handling of class or aggregate

@i-garrison
Copy link
Contributor Author

Hi @jonahgraham - hope this CI build issue is transient?

Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/glibc/libc6-dbg_2.31-0ubuntu9.9_amd64.deb

@i-garrison i-garrison force-pushed the pr/amend-list-initialization-sequence branch from 37d1c8b to 7a77945 Compare October 9, 2023 12:23
@i-garrison i-garrison marked this pull request as draft October 9, 2023 17:46
@i-garrison i-garrison marked this pull request as ready for review October 9, 2023 17:52
jonahgraham added a commit to jonahgraham/cdt that referenced this pull request Oct 9, 2023
@jonahgraham
Copy link
Member

Hi @jonahgraham - hope this CI build issue is transient?

Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/glibc/libc6-dbg_2.31-0ubuntu9.9_amd64.deb

There was a missing apt update in our script - fixed in #586 - please rebase changes once I merge #586 to pick up the fix.

@jonahgraham
Copy link
Member

(My commit message in #586 referenced this PR in a way that caused it to be auto-closed. Re-opening)

@jonahgraham jonahgraham reopened this Oct 9, 2023
@i-garrison i-garrison force-pushed the pr/amend-list-initialization-sequence branch from 90c076b to 21bdbb1 Compare October 10, 2023 00:16
@jonahgraham jonahgraham added the language C/C++ Language Support label Oct 11, 2023
@i-garrison
Copy link
Contributor Author

Hi @jonahgraham would you believe we can get this merged before 11.4.0 cutoff date?

Mind that #448 is conflicting with his one but we have an agreement to prefer this (larger) change #448 (comment)

@jonahgraham jonahgraham force-pushed the pr/amend-list-initialization-sequence branch from 21bdbb1 to 45c3ea0 Compare December 28, 2023 21:50
Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At recent CDT calls we discussed how to handle reviews where there is insufficient expertise to review amongst existing committers and decided to accept such changes that look reasonable and appear sufficiently tested.

I have pushed a rebased version of this change.

@jonahgraham jonahgraham force-pushed the pr/amend-list-initialization-sequence branch from 45c3ea0 to 5676220 Compare December 28, 2023 22:17
@jonahgraham
Copy link
Member

I bumped the cdt.ui and updated the dep on cdt core to make sure the method with the new parameter is properly picked up.

@jonahgraham jonahgraham merged commit 8091626 into eclipse-cdt:main Dec 28, 2023
4 checks passed
@i-garrison i-garrison deleted the pr/amend-list-initialization-sequence branch December 28, 2023 22:51
@jonahgraham jonahgraham added this to the 11.5.0 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language C/C++ Language Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants