Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static code analysis and doc link errors #112

Merged
merged 8 commits into from
Apr 5, 2023
Merged

Fix static code analysis and doc link errors #112

merged 8 commits into from
Apr 5, 2023

Conversation

devkelley
Copy link
Contributor

Partial fix for #98

Motivation and Context

This resolves current code static analysis errors and removes dead/inaccessible links in old documentation.

Description

Fixed static analysis code errors throughout the solution. This included recent and older code. Also removed some links that either no longer exist or are inaccessible. These links are in older documentation that has been superseded and thus are not critical to maintain.

@devkelley
Copy link
Contributor Author

Note the Lint and Check Markdown workflow fails because of a recent issue introduced in the new version related to the service not taking in the config file. The current link failures are only to localhost, which is ignored in the config. The workflow will pass once the issue is fixed. See issue: tcort/markdown-link-check#246

@fprezado fprezado merged commit eff76df into eclipse-chariott:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants