Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi and arm dockerfiles #265

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Conversation

devkelley
Copy link
Contributor

Motivation and Context

This adds a dockerfile that can cross-compile arm64 for docker buildx.

Description

Dockerfile.service_discovery.multi - can cross-compile either arm64 or amd64 images for service discovery
Dockerfile.service_discovery.arm64 - will build arm64 image with cross compile

Copy link
Contributor

@ladatz ladatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider my comments

Dockerfile.service_discovery.multi Show resolved Hide resolved
Dockerfile.service_discovery.multi Show resolved Hide resolved
Dockerfile.service_discovery.multi Outdated Show resolved Hide resolved
Dockerfile.service_discovery.multi Show resolved Hide resolved
Dockerfile.service_discovery.arm64 Outdated Show resolved Hide resolved
@ladatz ladatz marked this pull request as ready for review March 8, 2024 21:26
@ladatz
Copy link
Contributor

ladatz commented Mar 11, 2024

@devkelley also reviewed and approved.

@ladatz ladatz merged commit ad58e6c into main Mar 11, 2024
7 checks passed
@ladatz ladatz mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants