fixup! fixup! fixup! fix: certificate injection

eclipse-che · Mar 17, 2023 · d650365 · d650365
1 parent 39cfc27
commit d650365
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/packages/dashboard-frontend/src/containers/Loader/Factory/Steps/Apply/Devfile/index.tsx b/packages/dashboard-frontend/src/containers/Loader/Factory/Steps/Apply/Devfile/index.tsx
@@ -282,9 +282,12 @@ class StepApplyDevfile extends AbstractLoaderStep<Props, State> {
   }
 
   private async createWorkspaceFromDevfile(devfile: devfileApi.Devfile): Promise<void> {
-    const params = Object.fromEntries(this.props.searchParams);
     const optionalFilesContent = this.props.factoryResolver?.optionalFilesContent || {};
-    await this.props.createWorkspaceFromDevfile(devfile, params, optionalFilesContent);
+    await this.props.createWorkspaceFromDevfile(
+      devfile,
+      this.state.factoryParams,
+      optionalFilesContent,
+    );
   }
 
   private handleCreateWorkspaceError(): void {

diff --git a/packages/dashboard-frontend/src/store/Workspaces/devWorkspaces/index.ts b/packages/dashboard-frontend/src/store/Workspaces/devWorkspaces/index.ts
@@ -160,15 +160,15 @@ export type ActionCreators = {
   updateWorkspace: (workspace: devfileApi.DevWorkspace) => AppThunk<KnownAction, Promise<void>>;
   createWorkspaceFromDevfile: (
     devfile: devfileApi.Devfile,
-    attributes: Partial<FactoryParams>,
+    attributes: FactoryParams,
     optionalFilesContent: {
       [fileName: string]: string;
     },
   ) => AppThunk<KnownAction, Promise<void>>;
   createWorkspaceFromResources: (
     devWorkspace: devfileApi.DevWorkspace,
     devWorkspaceTemplate: devfileApi.DevWorkspaceTemplate,
-    editor?: string,
+    editorId?: string,
   ) => AppThunk<KnownAction, Promise<void>>;
 
   handleWebSocketMessage: (
@@ -574,7 +574,7 @@ export const actionCreators: ActionCreators = {
   createWorkspaceFromDevfile:
     (
       devfile: devfileApi.Devfile,
-      attributes: Partial<FactoryParams>,
+      attributes: FactoryParams,
       optionalFilesContent: {
         [fileName: string]: string;
       },

diff --git a/packages/dashboard-frontend/src/store/Workspaces/index.ts b/packages/dashboard-frontend/src/store/Workspaces/index.ts
@@ -108,7 +108,7 @@ export type ActionCreators = {
   updateWorkspace: (workspace: Workspace) => AppThunk<KnownAction, Promise<void>>;
   createWorkspaceFromDevfile: (
     devfile: devfileApi.Devfile,
-    attributes: Partial<FactoryParams>,
+    attributes: FactoryParams,
     optionalFilesContent?: {
       [fileName: string]: string;
     },
@@ -215,7 +215,7 @@ export const actionCreators: ActionCreators = {
   createWorkspaceFromDevfile:
     (
       devfile: devfileApi.Devfile,
-      attributes: Partial<FactoryParams>,
+      attributes: FactoryParams,
       optionalFilesContent?: {
         [fileName: string]: string;
       },