Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added expose URL parameters widget #1096

Merged
merged 1 commit into from
Apr 29, 2024
Merged

feat: added expose URL parameters widget #1096

merged 1 commit into from
Apr 29, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Apr 15, 2024

What does this PR do?

Added expose URL parameters widget

What issues does this PR fix or reference?

fixes eclipse-che/che#22816

Знімок екрана 2024-04-15 о 16 27 46

https://www.youtube.com/watch?v=MBf7NqObmVg

Is it tested? How?

  1. Deploy Eclipse-Che with the image from this PR.

  2. Try to create a new workspace with Github, GitLab, and Bitbucket repositories using the new URL parameters constructor. Change the Git Branch, the Path to Devfile, and add Git Remotes:
    https://www.youtube.com/watch?v=MBf7NqObmVg

  3. We should check that the URL parameters constructor has additional validations for each remote, recognizes Github, GitLab, and Bitbucket repositories, and properly changes branches.

@che-bot
Copy link
Contributor

che-bot commented Apr 15, 2024

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 force-pushed the CHE-22816 branch 2 times, most recently from d62c57d to 5e47431 Compare April 22, 2024 00:37
@olexii4 olexii4 marked this pull request as ready for review April 22, 2024 00:37
@olexii4 olexii4 force-pushed the CHE-22816 branch 3 times, most recently from b96baa7 to cbed3a8 Compare April 22, 2024 06:21
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@eclipse-che eclipse-che deleted a comment from codecov bot Apr 28, 2024
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1096

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1096", name: che-dashboard}]}}]"

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 89.31001% with 110 lines in your changes are missing coverage. Please review.

Project coverage is 89.08%. Comparing base (585302c) to head (fc87b18).

Files Patch % Lines
.../components/ImportFromGit/GitRepoOptions/index.tsx 73.45% 30 Missing ⚠️
...rd-frontend/src/components/ImportFromGit/index.tsx 80.00% 27 Missing ⚠️
...d-frontend/src/components/ImportFromGit/helpers.ts 89.82% 23 Missing ⚠️
.../GitRepoOptions/AdditionalGitRemotes/gitRemote.tsx 94.49% 13 Missing ⚠️
...mGit/GitRepoOptions/AdditionalGitRemotes/index.tsx 95.97% 6 Missing ⚠️
...ortFromGit/GitRepoOptions/GitBranchField/index.tsx 94.20% 4 Missing ⚠️
...gress/CreatingSteps/Apply/Devfile/getGitRemotes.ts 83.33% 4 Missing ⚠️
...romGit/GitRepoOptions/PathToDevfileField/index.tsx 95.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1096      +/-   ##
==========================================
+ Coverage   88.91%   89.08%   +0.16%     
==========================================
  Files         400      406       +6     
  Lines       40705    41696     +991     
  Branches     2692     2784      +92     
==========================================
+ Hits        36194    37146     +952     
- Misses       4482     4522      +40     
+ Partials       29       28       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eclipse-che eclipse-che deleted a comment from github-actions bot Apr 29, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Apr 29, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Apr 29, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Apr 29, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Apr 29, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Apr 29, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Apr 29, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Apr 29, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Apr 29, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Apr 29, 2024
@eclipse-che eclipse-che deleted a comment from openshift-ci bot Apr 29, 2024
@eclipse-che eclipse-che deleted a comment from openshift-ci bot Apr 29, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Apr 29, 2024
Copy link

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit b48d98b into main Apr 29, 2024
17 of 18 checks passed
@olexii4 olexii4 deleted the CHE-22816 branch April 29, 2024 14:01
@devstudio-release
Copy link

Build 3.14 :: dashboard_3.x/485: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.14 :: dashboard_3.x/485: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6661 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.14 :: get-sources-rhpkg-container-build_3.x/6618: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 60851563 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UD] Expose URL parameters to users(Git Repo Options)
5 participants