-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added expose URL parameters widget #1096
Conversation
d62c57d
to
5e47431
Compare
b96baa7
to
cbed3a8
Compare
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1096 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1096", name: che-dashboard}]}}]" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1096 +/- ##
==========================================
+ Coverage 88.91% 89.08% +0.16%
==========================================
Files 400 406 +6
Lines 40705 41696 +991
Branches 2692 2784 +92
==========================================
+ Hits 36194 37146 +952
- Misses 4482 4522 +40
+ Partials 29 28 -1 ☔ View full report in Codecov by Sentry. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.14 :: dashboard_3.x/485: Console, Changes, Git Data |
Build 3.14 :: sync-to-downstream_3.x/6661: Console, Changes, Git Data |
Build 3.14 :: push-latest-container-to-quay_3.x/4569: Console, Changes, Git Data |
Build 3.14 :: get-sources-rhpkg-container-build_3.x/6617: dashboard : 3.x :: Build 60851068 : quay.io/devspaces/dashboard-rhel8:3.14-6 |
Build 3.14 :: update-digests_3.x/6455: Console, Changes, Git Data |
Build 3.14 :: dashboard_3.x/485: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6661 triggered |
Build 3.14 :: operator-bundle_3.x/2933: Console, Changes, Git Data |
Build 3.14 :: sync-to-downstream_3.x/6662: Console, Changes, Git Data |
Build 3.14 :: get-sources-rhpkg-container-build_3.x/6618: devspaces-operator-bundle : 3.x :: Failed in 60851563 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
Added expose URL parameters widget
What issues does this PR fix or reference?
fixes eclipse-che/che#22816
https://www.youtube.com/watch?v=MBf7NqObmVg
Is it tested? How?
Deploy Eclipse-Che with the image from this PR.
Try to create a new workspace with Github, GitLab, and Bitbucket repositories using the new URL parameters constructor. Change the Git Branch, the Path to Devfile, and add Git Remotes:
https://www.youtube.com/watch?v=MBf7NqObmVg
We should check that the URL parameters constructor has additional validations for each remote, recognizes Github, GitLab, and Bitbucket repositories, and properly changes branches.