Restore the authorisation opt-out functionality

[vinokurig]

What does this PR do?

• Always decode url on factory url accept.
• Restore the skip oauth functionality.
  see: Implemented an ability to reject the authorisation opt-out flag from the dashboard #972

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-6245

Is it tested? How?

1. Configure GitHub oauth
2. Start a workspace from a GitHub repository with devfile.
3. When the authorisation page appears, click the Cancel button.
4. Go back to Dashboard -> User Preferences -> Git Services tab
5. See: a yellow warning sign is present in the GitHub item, click the kebab icon and then the Clear menu button.
6. See: the yellow sign is disappeared.

Release Notes

Docs PR

[che-bot]

Click here to review and test in web IDE:

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1098

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1098", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1098

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1098", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1098

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1098", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1098

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1098", name: che-dashboard}]}}]"

[ibuziuk]

/retest

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1098

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1098", name: che-dashboard}]}}]"

[artaleks9]

Verified on Eclipse Che with quay.io/eclipse/che-dashboard:pr-1098:

• GitHub.com - checking according to PR fix description - works as expected
• Bitbucket Server OAuth2 - checking according to Jira issue - works properly

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, artaleks9, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[devstudio-release]

Build 3.14 :: dashboard_3.x/482: Console, Changes, Git Data

[devstudio-release]

Build 3.14 :: sync-to-downstream_3.x/6581: Console, Changes, Git Data

[devstudio-release]

Build 3.14 :: get-sources-rhpkg-container-build_3.x/6537: Console, Changes, Git Data

[devstudio-release]

Build 3.14 :: push-latest-container-to-quay_3.x/4550: Console, Changes, Git Data

[devstudio-release]

Build 3.14 :: get-sources-rhpkg-container-build_3.x/6537:

dashboard : 3.x :: Build 60680606 : quay.io/devspaces/dashboard-rhel8:3.14-3
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4550 triggered

[devstudio-release]

Build 3.14 :: dashboard_3.x/482:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6581 triggered

[devstudio-release]

Build 3.14 :: update-digests_3.x/6394: Console, Changes, Git Data

[devstudio-release]

Build 3.14 :: operator-bundle_3.x/2872: Console, Changes, Git Data

[devstudio-release]

Build 3.14 :: sync-to-downstream_3.x/6582: Console, Changes, Git Data

[devstudio-release]

Build 3.14 :: get-sources-rhpkg-container-build_3.x/6538: Console, Changes, Git Data

[devstudio-release]

Build 3.14 :: get-sources-rhpkg-container-build_3.x/6538:

devspaces-operator-bundle : 3.x :: Failed in 60682577 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay