-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp Workspaces List #125
Conversation
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
This allows to write unit tests easier for components that use IoC. Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Code coverage diff between base branch:main-react and head branch: workspaces-list-revamp
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every issue I faced before seems to be fixed now and I did not find anything new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it looks like all issues I had were fixed
[dashboard-next-ci-test] |
✅ E2E dashboard-next tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
What does this PR do?
This PR provides a re-vamped workspaces list page fro React-based Dashboard.
Screenshot/screencast of this PR
Allows to sort workspaces by name or by modification time:
sort-order.mov
Allows to filter workspaces by name:
filter-workspaces.mov
Enable and disable workspace actions depending on the workspace status:
actions.mov
Delete a single running workspace:
UX is going to be improved in scope of Delete running workspaces on Workspaces List page eclipse-che/che#18761
delete-running-1.mov
Bulk delete workspaces including a running one:
delete-running-2.mov
What issues does this PR fix or reference?
Fixes eclipse-che/che#16646
Fixes eclipse-che/che#18609