Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Workspaces List #125

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Revamp Workspaces List #125

merged 4 commits into from
Jan 14, 2021

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR provides a re-vamped workspaces list page fro React-based Dashboard.

Screenshot/screencast of this PR

Screenshot 2021-01-11 at 15 40 14

Allows to sort workspaces by name or by modification time:

sort-order.mov

Allows to filter workspaces by name:

filter-workspaces.mov

Enable and disable workspace actions depending on the workspace status:

actions.mov

Delete a single running workspace:

UX is going to be improved in scope of Delete running workspaces on Workspaces List page eclipse-che/che#18761

delete-running-1.mov

Bulk delete workspaces including a running one:

delete-running-2.mov

What issues does this PR fix or reference?

Fixes eclipse-che/che#16646
Fixes eclipse-che/che#18609

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
This allows to write unit tests easier for components that use IoC.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@github-actions
Copy link

Code coverage diff between base branch:main-react and head branch: workspaces-list-revamp

File % Stmts % Branch % Funcs % Lines
total 44.66 49.59 31.29 33.38 43.21 49 44.4 49.45
src/Layout/Navigation/isActive.ts 100 100 100 100
src/containers/WorkspacesList.tsx 91.67 100 66.67 91.67
src/containers/WorkspaceActions/context.tsx 75 100 50 75
src/containers/WorkspaceActions/index.tsx 81.82 62.96 100 81.33
src/pages/WorkspaceDetails/Header/Actions/index.tsx 73.53 72.73 28.57 28.57 71.43 71.43 73.53 72.73
src/pages/WorkspacesList/Rows.tsx 70.18 30 85.71 70.18
src/pages/WorkspacesList/index.tsx 72.51 45.65 76.74 73.62
src/pages/WorkspacesList/EmptyState/NoWorkspaces.tsx 83.33 100 50 83.33
src/pages/WorkspacesList/EmptyState/NothingFound.tsx 100 100 100 100
src/pages/WorkspacesList/Toolbar/index.tsx 93.18 80 100 93.18
src/services/alerts/appAlerts.ts 95.24 95 50 50 88.89 88.89 94.44 94.12
src/services/helpers/date.ts 60 100 0 60
src/services/helpers/filter.ts 100 100 100 100
src/services/helpers/location.ts 80 50 100 80
src/services/helpers/random.ts 100 100 100 100
src/services/keycloak/setup.ts 11.76 0 0 10.1
src/store/DevfileRegistries/selectors.ts 89.47 78.57 25 16.67 90 66.67 87.5 83.33
src/store/Workspaces/index.ts 7.1 0 0 7.1

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every issue I faced before seems to be fixed now and I did not find anything new

Copy link
Contributor

@JPinkney JPinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it looks like all issues I had were fixed

@Ohrimenko1988
Copy link
Contributor

[dashboard-next-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jan 14, 2021

✅ E2E dashboard-next tests succeed 🎉

See Details

  • Jenkins job

  • logs and configs

  • Che dashboard-next image:docker.io/maxura/che-dashboard:125

  • Che server image: docker.io/maxura/che-server:125

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

@akurinnoy akurinnoy merged commit 7e9ebd0 into main-react Jan 14, 2021
@akurinnoy akurinnoy deleted the workspaces-list-revamp branch January 14, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants