Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error messages #273

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Fix error messages #273

merged 3 commits into from
Jun 22, 2021

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR fixes messages for the errors happening while creating a new workspace, or updating an existing one.

What issues does this PR fix or reference?

fixes eclipse-che/che#19945
provides a clearer error message for eclipse-che/che#19922

@akurinnoy akurinnoy self-assigned this Jun 17, 2021
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #273 (baf7aa0) into main (c27db63) will increase coverage by 1.30%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   50.00%   51.30%   +1.30%     
==========================================
  Files         143      143              
  Lines        5410     5409       -1     
  Branches      882      880       -2     
==========================================
+ Hits         2705     2775      +70     
+ Misses       2455     2374      -81     
- Partials      250      260      +10     
Impacted Files Coverage Δ
src/containers/WorkspaceDetails.tsx 0.00% <0.00%> (ø)
src/pages/GetStarted/index.tsx 70.42% <0.00%> (ø)
src/store/Workspaces/index.ts 6.08% <0.00%> (+0.57%) ⬆️
src/services/helpers/getErrorMessage.ts 100.00% <100.00%> (+44.44%) ⬆️
src/components/DevfileEditor/index.tsx 28.12% <0.00%> (-0.30%) ⬇️
src/services/workspaceAdapter/index.ts 68.36% <0.00%> (+3.06%) ⬆️
src/pages/WorkspaceDetails/EditorTab/index.tsx 55.55% <0.00%> (+55.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c27db63...baf7aa0. Read the comment docs.

@github-actions
Copy link

Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-273

@che-bot
Copy link
Contributor

che-bot commented Jun 17, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and did not face undefined in the error messages.

Copy link
Contributor

@JPinkney JPinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-273

@che-bot
Copy link
Contributor

che-bot commented Jun 18, 2021

❌ E2E dashboard tests failed ❗

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@sleshchenko
Copy link
Member

[dashboard-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jun 18, 2021

❌ E2E dashboard tests failed ❗

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@sleshchenko
Copy link
Member

[dashboard-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jun 18, 2021

❌ E2E dashboard tests failed ❗

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@akurinnoy akurinnoy merged commit 73f536d into main Jun 22, 2021
@akurinnoy akurinnoy deleted the fix-create-workspace-undefined branch June 22, 2021 07:06
@che-bot che-bot added this to the 7.33 milestone Jun 22, 2021
akurinnoy added a commit that referenced this pull request Jun 22, 2021
sleshchenko pushed a commit that referenced this pull request Jun 22, 2021
akurinnoy added a commit that referenced this pull request Jun 23, 2021
@akurinnoy akurinnoy mentioned this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message should be more helpful at creation a workspace
5 participants