-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error messages #273
Fix error messages #273
Conversation
…ces store and Dev workspaces store
Codecov Report
@@ Coverage Diff @@
## main #273 +/- ##
==========================================
+ Coverage 50.00% 51.30% +1.30%
==========================================
Files 143 143
Lines 5410 5409 -1
Branches 882 880 -2
==========================================
+ Hits 2705 2775 +70
+ Misses 2455 2374 -81
- Partials 250 260 +10
Continue to review full report at Codecov.
|
Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-273 |
✅ E2E dashboard tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and did not face undefined
in the error messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-273 |
❌ E2E dashboard tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
[dashboard-ci-test] |
❌ E2E dashboard tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
[dashboard-ci-test] |
❌ E2E dashboard tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
What does this PR do?
This PR fixes messages for the errors happening while creating a new workspace, or updating an existing one.
What issues does this PR fix or reference?
fixes eclipse-che/che#19945
provides a clearer error message for eclipse-che/che#19922