Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devfile V1 update flow when devworkspace is enabled #285

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jun 24, 2021

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Fix devfile V1 update flow when devworkspace is enabled.

What issues does this PR fix or reference?

fixes eclipse-che/che#19922

Release Notes

Docs PR

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #285 (e2142fa) into main (37f6166) will increase coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
+ Coverage   51.28%   51.30%   +0.01%     
==========================================
  Files         143      143              
  Lines        5407     5405       -2     
  Branches      880      880              
==========================================
  Hits         2773     2773              
+ Misses       2374     2372       -2     
  Partials      260      260              
Impacted Files Coverage Δ
src/store/Workspaces/index.ts 6.19% <25.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37f6166...e2142fa. Read the comment docs.

src/store/Workspaces/index.ts Show resolved Hide resolved
@sleshchenko
Copy link
Member

@olexii4 after merging please cherry-pick into 7.32.x as well. Thx

@github-actions
Copy link

Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-285

@che-bot
Copy link
Contributor

che-bot commented Jun 24, 2021

❌ E2E dashboard tests failed ❗

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@sleshchenko
Copy link
Member

[dashboard-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jun 25, 2021

❌ E2E dashboard tests failed ❗

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@olexii4
Copy link
Contributor Author

olexii4 commented Jun 25, 2021

[dashboard-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jun 25, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@olexii4 olexii4 merged commit 02f444b into main Jun 25, 2021
@olexii4 olexii4 deleted the CHE-19922 branch June 25, 2021 10:12
@che-bot che-bot added this to the 7.33 milestone Jun 25, 2021
@olexii4 olexii4 mentioned this pull request Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to save changes to devfile
5 participants