-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard warns users that Safari is not supported #315
Conversation
Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-315 |
✅ E2E dashboard tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Codecov Report
@@ Coverage Diff @@
## main #315 +/- ##
==========================================
- Coverage 52.10% 52.07% -0.04%
==========================================
Files 146 148 +2
Lines 5617 5640 +23
Branches 921 923 +2
==========================================
+ Hits 2927 2937 +10
- Misses 2413 2426 +13
Partials 277 277
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4, sleshchenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
please, after merging create PR with cherry-pick the stuff onto 7.34.x |
What does this PR do?
In this PR I added the fix that allows Dashboard to run in Safari. And since Safari is not supported users will always see the permanent banner with the warning message at the top of the page.
What issues does this PR fix or reference?
fixes eclipse-che/che#20123