Add ability to open cluster web console from Dashboard #378

akurinnoy · 2021-10-08T12:14:35Z

What does this PR do?

This PR adds an application launcher into the page masthead. As for now, app launcher contains one item that allows users to open the cluster Web UI page.

What issues does this PR fix or reference?

resolves eclipse-che/che#20106

Is it tested? How?

Release Notes

Docs PR

openshift-ci · 2021-10-08T12:14:37Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

codecov · 2021-10-08T12:20:36Z

Codecov Report

Merging #378 (ef9b1b4) into main (b6943a2) will increase coverage by 0.10%.
The diff coverage is 72.76%.

❗ Current head ef9b1b4 differs from pull request most recent head 9e77b85. Consider uploading reports for the commit 9e77b85 to get more accurate results

@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   48.99%   49.10%   +0.10%     
==========================================
  Files         194      201       +7     
  Lines        6643     6765     +122     
  Branches     1065     1089      +24     
==========================================
+ Hits         3255     3322      +67     
- Misses       3078     3126      +48     
- Partials      310      317       +7

Impacted Files	Coverage Δ
packages/dashboard-backend/src/api/clusterInfo.ts	`0.00% <0.00%> (ø)`
...ackages/dashboard-backend/src/constants/schemas.ts	`0.00% <0.00%> (ø)`
...d/src/devworkspace-client/services/cluster-info.ts	`0.00% <0.00%> (ø)`
...ges/dashboard-frontend/src/Layout/Header/index.tsx	`66.66% <ø> (-2.09%)`	⬇️
...ard-frontend/src/services/bootstrap/PreloadData.ts	`0.00% <0.00%> (ø)`
packages/dashboard-frontend/src/store/helpers.ts	`100.00% <ø> (ø)`
packages/dashboard-frontend/src/store/index.ts	`0.00% <0.00%> (ø)`
...rontend/src/Layout/Header/Tools/UserMenu/index.tsx	`66.66% <66.66%> (ø)`
...ontend/src/Layout/Header/Tools/AboutMenu/index.tsx	`74.28% <74.28%> (ø)`
...shboard-frontend/src/Layout/Header/Tools/index.tsx	`87.50% <80.00%> (+15.23%)`	⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6943a2...9e77b85. Read the comment docs.

github-actions · 2021-10-08T12:31:04Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-378

che-bot · 2021-10-08T12:34:03Z

✅ E2E dashboard tests succeed 🎉

See Details

Jenkins job
test report
logs and configs
Che dashboard image:quay.io/crw_pr/che-dashboard:378
Che server image: quay.io/crw_pr/che-server:378

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

sleshchenko · 2021-10-11T15:13:55Z

Tested with eclipse-che/che-operator#1132 and it seems to work.
Probably we need avoid using RedHat in upstream and then override it on the downstream side.
The upstream way is under discussion, it may be just Applications or Related Applications

github-actions · 2021-10-12T11:27:46Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-378

che-bot · 2021-10-12T11:31:25Z

✅ E2E dashboard tests succeed 🎉

See Details

Jenkins job
test report
logs and configs
Che dashboard image:quay.io/crw_pr/che-dashboard:378
Che server image: quay.io/crw_pr/che-server:378

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

github-actions · 2021-10-19T12:46:26Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-378

che-bot · 2021-10-19T12:50:26Z

✅ E2E dashboard tests succeed 🎉

See Details

Jenkins job
test report
logs and configs
Che dashboard image:quay.io/crw_pr/che-dashboard:378
Che server image: quay.io/crw_pr/che-server:378

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

packages/common/src/dto/application-info.ts

github-actions · 2021-10-20T08:24:09Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-378

github-actions · 2021-10-20T08:29:36Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-378

che-bot · 2021-10-20T08:35:50Z

✅ E2E dashboard tests succeed 🎉

See Details

Jenkins job
test report
logs and configs
Che dashboard image:quay.io/crw_pr/che-dashboard:378
Che server image: quay.io/crw_pr/che-server:378

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

github-actions · 2021-10-20T09:47:37Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-378

che-bot · 2021-10-20T09:53:25Z

✅ E2E dashboard tests succeed 🎉

See Details

Jenkins job
test report
logs and configs
Che dashboard image:quay.io/crw_pr/che-dashboard:378
Che server image: quay.io/crw_pr/che-server:378

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

github-actions · 2021-10-20T11:37:02Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-378

packages/dashboard-backend/src/devworkspace-client/services/cluster-info.ts

github-actions · 2021-10-20T11:40:54Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-378

olexii4 · 2021-10-20T11:45:29Z

I have tested it. Looks good, but it has several small issues:

Swagger (wrong schema for the GET request)

che-bot · 2021-10-20T11:47:41Z

✅ E2E dashboard tests succeed 🎉

See Details

Jenkins job
test report
logs and configs
Che dashboard image:quay.io/crw_pr/che-dashboard:378
Che server image: quay.io/crw_pr/che-server:378

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

akurinnoy · 2021-10-20T11:49:23Z

@olexii4 Could you add some details for the pictures you posted?
I see that icon is not found, maybe something else wrong there?
What is the cluster console URL?

akurinnoy · 2021-10-20T11:56:22Z

@olexii4 I got it, the second picture shows the REST method returns an object with empty fields, and the first picture shows how Dashboard renders that. Thanks, I'm fixing that.

Update: the offline discussion reveals that I got it a bit wrong, there are two separate questions and only one with swagger (request schema) should be fixed.

packages/dashboard-backend/src/api/clusterInfo.ts

openshift-ci · 2021-10-20T12:28:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4, sleshchenko

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-10-20T12:31:18Z

New changes are detected. LGTM label has been removed.

github-actions · 2021-10-20T12:45:25Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-378

che-bot · 2021-10-20T12:48:14Z

✅ E2E dashboard tests succeed 🎉

See Details

Jenkins job
test report
logs and configs
Che dashboard image:quay.io/crw_pr/che-dashboard:378
Che server image: quay.io/crw_pr/che-server:378

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

akurinnoy · 2021-10-20T13:57:05Z

/test v7-dashboard-happy-path

github-actions · 2021-10-25T11:35:49Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-378

openshift-ci · 2021-10-25T12:37:16Z

@akurinnoy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v7-dashboard-happy-path	`fbe2ccd`	link	true	`/test v7-dashboard-happy-path`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci bot added the do-not-merge/work-in-progress label Oct 8, 2021

akurinnoy requested review from sleshchenko and olexii4 October 8, 2021 12:14

sleshchenko changed the title ~~chore(fronend): refactor HeaderTools component~~ chore(frontend): refactor HeaderTools component Oct 11, 2021

akurinnoy changed the title ~~chore(frontend): refactor HeaderTools component~~ Add ability to open cluster web console from Dashboard Oct 12, 2021

akurinnoy marked this pull request as ready for review October 12, 2021 14:56

openshift-ci bot removed the do-not-merge/work-in-progress label Oct 12, 2021

sleshchenko reviewed Oct 19, 2021

View reviewed changes

packages/common/src/dto/application-info.ts Show resolved Hide resolved

sleshchenko approved these changes Oct 19, 2021

View reviewed changes

openshift-ci bot assigned sleshchenko Oct 19, 2021

openshift-ci bot added lgtm and removed lgtm labels Oct 19, 2021

sleshchenko modified the milestones: 7.39, 7.36 Oct 20, 2021

olexii4 reviewed Oct 20, 2021

View reviewed changes

packages/dashboard-backend/src/devworkspace-client/services/cluster-info.ts Show resolved Hide resolved

olexii4 reviewed Oct 20, 2021

View reviewed changes

packages/dashboard-backend/src/api/clusterInfo.ts Outdated Show resolved Hide resolved

akurinnoy and others added 7 commits October 20, 2021 15:26

chore(fronend): refactor HeaderTools component

55d9d6c

feat(frontend): added redux store for external applications

7429bc5

feat(frontend): add ApplicationsMenu component

c643720

fix(frontend): use Clipboard API instead of deprecated execCommand

fc817c5

feat(backend): register 'api/cluster-info' route

88f5159

refactor: make applications menu extendable

3d5b1c3

proposal for external application menu configuration description

7e2091f

olexii4 approved these changes Oct 20, 2021

View reviewed changes

openshift-ci bot assigned olexii4 Oct 20, 2021

openshift-ci bot added the lgtm label Oct 20, 2021

akurinnoy force-pushed the console-link branch from fb7a8ef to 7e2091f Compare October 20, 2021 12:31

openshift-ci bot removed the lgtm label Oct 20, 2021

Merge remote-tracking branch 'origin' into console-link

fbe2ccd

akurinnoy merged commit 45f65e6 into main Oct 25, 2021

akurinnoy deleted the console-link branch October 25, 2021 12:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to open cluster web console from Dashboard #378

Add ability to open cluster web console from Dashboard #378

akurinnoy commented Oct 8, 2021

openshift-ci bot commented Oct 8, 2021

codecov bot commented Oct 8, 2021 •

edited

Loading

github-actions bot commented Oct 8, 2021

che-bot commented Oct 8, 2021

sleshchenko commented Oct 11, 2021

github-actions bot commented Oct 12, 2021

che-bot commented Oct 12, 2021

github-actions bot commented Oct 19, 2021

che-bot commented Oct 19, 2021

github-actions bot commented Oct 20, 2021

github-actions bot commented Oct 20, 2021

che-bot commented Oct 20, 2021

github-actions bot commented Oct 20, 2021

che-bot commented Oct 20, 2021

github-actions bot commented Oct 20, 2021

github-actions bot commented Oct 20, 2021

olexii4 commented Oct 20, 2021 •

edited

Loading

che-bot commented Oct 20, 2021

akurinnoy commented Oct 20, 2021 •

edited

Loading

akurinnoy commented Oct 20, 2021 •

edited

Loading

openshift-ci bot commented Oct 20, 2021

openshift-ci bot commented Oct 20, 2021

github-actions bot commented Oct 20, 2021

che-bot commented Oct 20, 2021

akurinnoy commented Oct 20, 2021

github-actions bot commented Oct 25, 2021

openshift-ci bot commented Oct 25, 2021

Add ability to open cluster web console from Dashboard #378

Add ability to open cluster web console from Dashboard #378

Conversation

akurinnoy commented Oct 8, 2021

What does this PR do?

What issues does this PR fix or reference?

Is it tested? How?

Release Notes

Docs PR

openshift-ci bot commented Oct 8, 2021

codecov bot commented Oct 8, 2021 • edited Loading

Codecov Report

github-actions bot commented Oct 8, 2021

che-bot commented Oct 8, 2021

sleshchenko commented Oct 11, 2021

github-actions bot commented Oct 12, 2021

che-bot commented Oct 12, 2021

github-actions bot commented Oct 19, 2021

che-bot commented Oct 19, 2021

github-actions bot commented Oct 20, 2021

github-actions bot commented Oct 20, 2021

che-bot commented Oct 20, 2021

github-actions bot commented Oct 20, 2021

che-bot commented Oct 20, 2021

github-actions bot commented Oct 20, 2021

github-actions bot commented Oct 20, 2021

olexii4 commented Oct 20, 2021 • edited Loading

che-bot commented Oct 20, 2021

akurinnoy commented Oct 20, 2021 • edited Loading

akurinnoy commented Oct 20, 2021 • edited Loading

openshift-ci bot commented Oct 20, 2021

openshift-ci bot commented Oct 20, 2021

github-actions bot commented Oct 20, 2021

che-bot commented Oct 20, 2021

akurinnoy commented Oct 20, 2021

github-actions bot commented Oct 25, 2021

openshift-ci bot commented Oct 25, 2021

codecov bot commented Oct 8, 2021 •

edited

Loading

olexii4 commented Oct 20, 2021 •

edited

Loading

akurinnoy commented Oct 20, 2021 •

edited

Loading

akurinnoy commented Oct 20, 2021 •

edited

Loading