fix: complete support of che-editor.yaml file

[benoitf]

What does this PR do?

Handle id, reference, inline and override properties

What issues does this PR fix or reference?

Fixes eclipse-che/che#20715

Is it tested? How?

Tested with default samples and in addition:

• https://github.com/benoitf/override-editor-memory (id definition + override)
• https://github.com/benoitf/use-reference-editor (external definition + override)
• https://github.com/benoitf/exvscd (ide is not displayed directly but we can see that it's using the inline definition)

Release Notes

Docs PR

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-396

[che-bot]

✅ E2E dashboard tests succeed 🎉

See Details

• Jenkins job

• test report

• logs and configs

• Che dashboard image:quay.io/crw_pr/che-dashboard:396

• Che server image: quay.io/crw_pr/che-server:396

Test product:

• tested with Eclipse Che on K8S (minikube v1.22.0)
• E2E test scenario
• E2E test pipeline source code

• Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

[codecov]

Codecov Report

Merging #396 (0c295e8) into main (82e01c0) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   48.81%   48.63%   -0.19%     
==========================================
  Files         207      207              
  Lines        7180     7207      +27     
  Branches     1203     1214      +11     
==========================================
  Hits         3505     3505              
- Misses       3301     3328      +27     
  Partials      374      374              

Impacted Files	Coverage Δ
...orkspace-client/devworkspace/devWorkspaceClient.ts	41.95% <0.00%> (-4.38%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e01c0...0c295e8. Read the comment docs.

[benoitf]

it would be nice to have it included in the upcoming tag 7.39

[olexii4]

It will cause 'has been blocked by CORS policy' error as we see with your example:

...
reference: https://eclipse-che.github.io/che-plugin-registry/main/v3/plugins/eclipse/che-theia/next/devfile.yaml
...

It should be done on the dashboard-backend

.

[benoitf]

@olexii4 it's strange, github.io is allowing CORS
requests are returning access-control-allow-origin: * and it was working on my side

[olexii4]

I like this proposal. I have tested it. It works except CORS error which happens in the case with external reference (e.q. https://eclipse-che.github.io/che-plugin-registry/main/v3/plugins/eclipse/che-theia/next/devfile.yaml).

I agree to merge it if we open an issue to add tests for this important functionality (because we already have one regression eclipse-che/che#20737 with P1 and we should prevent it in the future).

[benoitf]

I agree to merge it if we open an issue to add tests for this important functionality (because we already have one regression eclipse-che/che#20737 with P1 and we should prevent it in the future).

@olexii4 it's not already handled by eclipse-che/che#20733 ?

[olexii4]

@olexii4 it's not already handled by eclipse-che/che#20733 ?

It is about IDE loading(IDE-loader) it is not cowering the Factory flow. But OK. I will add a comment to this issue.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, benoitf, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment