-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to the latest theia DW library #405
Conversation
- Add volume components if plug-ins have defined volumeMounts - Handle override of che-theia-plugins
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-405 |
✅ E2E dashboard tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
@benoitf: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, benoitf, ibuziuk, olexii4, svor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
it seems happy path test is borked. |
What does this PR do?
Use last version of the library:
What issues does this PR fix or reference?
Fixes eclipse-che/che#20805
Fixes eclipse-che/che#20596
Is it tested? How?
Use tests provided by the two PRs:
eclipse-che/che-theia#1262
eclipse-che/che-theia#1263
I tested using:
https://<che-host>#https://github.com/l0rd/spring-petclinic?devfilePath=.devfilev2.yaml
should succeed instead of reporting an error as todayhttps://<che-host>#https://github.com/svor/java-spring-petclinic/tree/sv-che-preferences
and check that java language server is started with LightWeight modeRelease Notes
Docs PR