Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to the latest theia DW library #405

Merged
merged 1 commit into from
Nov 23, 2021
Merged

feat: update to the latest theia DW library #405

merged 1 commit into from
Nov 23, 2021

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Nov 22, 2021

What does this PR do?

Use last version of the library:

  • Add volume components if plug-ins have defined volumeMounts
  • Handle override of che-theia-plugins

What issues does this PR fix or reference?

Fixes eclipse-che/che#20805
Fixes eclipse-che/che#20596

Is it tested? How?

Use tests provided by the two PRs:
eclipse-che/che-theia#1262
eclipse-che/che-theia#1263

I tested using:

  • start from https://<che-host>#https://github.com/l0rd/spring-petclinic?devfilePath=.devfilev2.yaml should succeed instead of reporting an error as today
  • start from https://<che-host>#https://github.com/svor/java-spring-petclinic/tree/sv-che-preferences and check that java language server is started with LightWeight mode

Release Notes

Docs PR

- Add volume components if plug-ins have defined volumeMounts
- Handle override of che-theia-plugins
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-405

@benoitf benoitf requested a review from svor November 22, 2021 15:53
@che-bot
Copy link
Contributor

che-bot commented Nov 22, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@openshift-ci
Copy link

openshift-ci bot commented Nov 22, 2021

@benoitf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v7-dashboard-happy-path 4f82b59 link true /test v7-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Nov 23, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, benoitf, ibuziuk, olexii4, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benoitf
Copy link
Contributor Author

benoitf commented Nov 23, 2021

it seems happy path test is borked.
Merging as agreed by owners

@benoitf benoitf merged commit f561846 into main Nov 23, 2021
@benoitf benoitf deleted the CHE-20805 branch November 23, 2021 13:14
@che-bot che-bot added this to the 7.40 milestone Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants