-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix v2.2.0 -> v1 devWorkspaces #419
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
=======================================
Coverage 49.40% 49.40%
=======================================
Files 210 210
Lines 7232 7232
Branches 1194 1194
=======================================
Hits 3573 3573
Misses 3315 3315
Partials 344 344 Continue to review full report at Codecov.
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-419 |
✅ E2E dashboard tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, benoitf, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Handle v2.2.0 -> v1 devfiles (even invalid devfiles like the one in OpenShift console)
For che-server workspaces. Do not try with devWorkspace mode
depends on eclipse-che/che-server#189
What issues does this PR fix or reference?
closes eclipse-che/che#20856
Is it tested? How?
2.2.0 example with invalid workingdirectory
https://che-server#https://github.com/devfile-samples/devfile-sample-code-with-quarkus
2.2.0 example with invalid workingdirectory
https://che-server#https://github.com/devfile-samples/devfile-sample-java-springboot-basic
invalid place-holder image and invalid image
https://che-server#https://github.com/devfile-samples/devfile-sample-java-springboot-basic/tree/03d097ddbe0c8b4e6a413c75199b48a3086b7afd
Release Notes
Docs PR