Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix v2.2.0 -> v1 devWorkspaces #419

Merged
merged 1 commit into from
Dec 6, 2021
Merged

feat: fix v2.2.0 -> v1 devWorkspaces #419

merged 1 commit into from
Dec 6, 2021

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Dec 3, 2021

What does this PR do?

Handle v2.2.0 -> v1 devfiles (even invalid devfiles like the one in OpenShift console)

For che-server workspaces. Do not try with devWorkspace mode

depends on eclipse-che/che-server#189

What issues does this PR fix or reference?

closes eclipse-che/che#20856

Is it tested? How?

2.2.0 example with invalid workingdirectory
https://che-server#https://github.com/devfile-samples/devfile-sample-code-with-quarkus

2.2.0 example with invalid workingdirectory
https://che-server#https://github.com/devfile-samples/devfile-sample-java-springboot-basic


invalid place-holder image and invalid image
https://che-server#https://github.com/devfile-samples/devfile-sample-java-springboot-basic/tree/03d097ddbe0c8b4e6a413c75199b48a3086b7afd

Release Notes

Docs PR

@openshift-ci

This comment has been minimized.

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #419 (ad1c34f) into main (d60de97) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #419   +/-   ##
=======================================
  Coverage   49.40%   49.40%           
=======================================
  Files         210      210           
  Lines        7232     7232           
  Branches     1194     1194           
=======================================
  Hits         3573     3573           
  Misses       3315     3315           
  Partials      344      344           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60de97...ad1c34f. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-419

@che-bot
Copy link
Contributor

che-bot commented Dec 3, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@benoitf benoitf marked this pull request as ready for review December 4, 2021 20:33
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, benoitf, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benoitf benoitf merged commit 37f9103 into main Dec 6, 2021
@benoitf benoitf deleted the CHE-20856 branch December 6, 2021 09:49
@che-bot che-bot added this to the 7.41 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devfile library converter handling of v2.2 to v1
4 participants